editor: compass sync + fast align-to-north#478
Conversation
- Remove CSS transition on compass needle SVG so rotation tracks exactly without rubber-band lag (was transition-transform 150ms) - Drive compass needle imperatively via ref when floorplan panel is hidden (3D-only mode), avoiding per-frame React re-renders of the full SVG while keeping the needle live - Align-to-north in 3D-only mode derives from latestNavigationSyncPose instead of stale viewport, publishes directly to the 3D camera - Temporarily lower camera-controls smoothTime from 0.25s to 0.18s during 2D-origin transitions (SmoothDamp τ≈90ms matches the 2D exponential decay), restoring on completion or cancellation Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Route all pending-pose cancellations through clearPendingFloorplanNavigationPose() so savedSmoothTime is always restored. Add a controlstart listener to catch right-click orbit and other pointer drags that weren't handled. Guard the rotation-degree ref mirror to prevent React re-renders from clobbering the imperative 3D-owned value when the panel is hidden, and add a useLayoutEffect to keep the needle DOM in sync. Make the catch-up effect re-run directly on panel reopen. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d4f1053. Configure here.
| azimuth: northAzimuth, | ||
| viewWidth: pose.viewWidth, | ||
| }) | ||
| return |
There was a problem hiding this comment.
Compass stuck after 3D north
Medium Severity
After an 'align to north' action, the compass needle and floorplan view can become stale or jump. The action publishes a source: '2d' navigation pose, but the floorplan's update logic (for the hidden compass and re-opened view) expects source: '3d' poses. This mismatch, compounded by 3d pose suppression during camera damping, prevents proper synchronization.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit d4f1053. Configure here.
| // When hidden, the imperative 3D path owns the ref and must not be clobbered. | ||
| if (isFloorplanOpenRef.current) { | ||
| latestFloorplanUserRotationDegRef.current = floorplanUserRotationDeg | ||
| } |
There was a problem hiding this comment.
Stale compass on panel reopen
Medium Severity
When the 2D panel opens after 3D-only orbit, the first render copies stale floorplanUserRotationDeg state into latestFloorplanUserRotationDegRef and reapplies it on the compass via React style, overwriting the live imperative rotation. Catch-up runs in a later useEffect, so the needle (and floorplan rotation) can visibly snap or flash wrong for at least one paint.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit d4f1053. Configure here.
1 participant
What does this PR do?
Fixes the compass widget lagging behind and desyncing from the 2D/3D view orientation:
smoothTime = 0.18(SmoothDamp effective τ = 90ms, matching the 2D panel's exponential decay constant), restored on completion or interruption. All pending-pose cancel paths route throughclearPendingFloorplanNavigationPose, and acontrolstartlistener catches user drags mid-transition, so the override can't leak into normal camera feel.How to test
bun dev, open a scene with a building.Screenshots / screen recording
N/A — verified locally by @aymericrabot (interactive change; recording can be added if needed).
Checklist
bun devbun checkto verify)mainbranch🤖 Generated with Claude Code
Note
Medium Risk
Touches per-frame navigation sync and global camera damping; incorrect smoothTime cleanup could affect normal 3D navigation feel, but changes are scoped to editor camera/floorplan UX with explicit restore paths.
Overview
Fixes compass lag and 2D/3D orientation drift when the floorplan panel is hidden or during synced navigation moves.
The compass needle drops its CSS transition and, in 3D-only mode, updates via a ref + inline transform from the navigation-sync store so it tracks the camera every frame without re-rendering the floorplan SVG. A layout effect reapplies the authoritative rotation ref so unrelated React renders do not snap the needle to stale state. Align-to-north while the panel is closed now publishes from the live 3D pose instead of a stale 2D viewport; reopening the floorplan still catches up from 3D-originated sync when the panel is open.
2D-originated camera moves temporarily set CameraControls
smoothTimeto 0.18 (matched to the 2D panel decay);clearPendingFloorplanNavigationPoserestores the saved value on completion or interruption (keyboard pan, wheel, pointer, and newcontrolstartfor user orbit/pan/touch mid-transition).Reviewed by Cursor Bugbot for commit d4f1053. Bugbot is set up for automated code reviews on this repo. Configure here.