fix(mcp): keep store receiver bound in scene event operations

[konevenkatesh]

Summary

SceneOperationsFacade.appendSceneEvent and listSceneEvents detached the store methods from the store instance before invoking them:

const append = this.requireStore().appendSceneEvent
if (!append) return null
return append(options) // `this` is undefined inside the store method

For store implementations that rely on this — SqliteSceneStore calls this.withWriteTransaction(...) inside appendSceneEvent — the detached call crashes with:

TypeError: undefined is not an object (evaluating 'this.withWriteTransaction')

Because the underlying SQLite write happens inside the transaction helper that never runs (append) or runs after the row insert (depending on path), every save_scene, create_from_template, and live-sync mutation routed through the MCP facade reported this error to the client even when the scene row itself had been persisted, making the MCP server unusable for headless scene building.

Reproduction

Run any scene save through the pascal-mcp CLI under Bun (e.g. connect an MCP client and call save_scene, or any template/live-sync tool that appends scene events). The tool call returns undefined is not an object (evaluating 'this.withWriteTransaction').

Fix

Invoke the optional methods on the store instance so the receiver stays bound:

const store = this.requireStore()
if (!store.appendSceneEvent) return null
return store.appendSceneEvent(options)

Same change for listSceneEvents.

Tests

Added packages/mcp/src/operations/scene-operations.test.ts:

• a facade-level regression test that appends/lists scene events through createSceneOperations backed by a real SqliteSceneStore — this fails with the exact TypeError above before the fix and passes after;
• a test covering the fallback behavior when the store does not implement scene events (appendSceneEvent → null, listSceneEvents → scene_events_unavailable).

bun test in packages/mcp: 295 pass, 0 fail. bun check reports no findings in the changed files.

🤖 Generated with Claude Code

---

Note

Low Risk
Small, localized fix mirroring other facade store calls; tests cover the failure mode and optional-store fallbacks.

Overview
Fixes a this binding bug in SceneOperationsFacade that broke MCP scene event APIs when backed by SqliteSceneStore.

appendSceneEvent and listSceneEvents no longer copy store methods into locals before calling them. They now invoke store.appendSceneEvent(...) and store.listSceneEvents(...) on the store instance so methods that use this (e.g. withWriteTransaction during append) run correctly. That removes the undefined is not an object (evaluating 'this.withWriteTransaction') failures on headless saves and related tools.

Adds scene-operations.test.ts: a regression test through createSceneOperations + SqliteSceneStore, plus coverage when the store omits scene events (null / scene_events_unavailable).

^{Reviewed by Cursor Bugbot for commit ef80fa3. Bugbot is set up for automated code reviews on this repo. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

^{Reviewed by Cursor Bugbot for commit ef80fa3. Configure here.}

[cursor]

Test leaves SQLite handle open

Low Severity

The afterEach hook removes the temporary database directory without closing the SqliteSceneStore instance. This can leave SQLite database files locked, causing fs.rm to fail (e.g., EBUSY on Windows) and potentially leaking file handles. Other tests correctly close the store before cleanup.

 

^{Reviewed by Cursor Bugbot for commit ef80fa3. Configure here.}