From 4b6b00f234c8504caf0670777e145f375807e4db Mon Sep 17 00:00:00 2001 From: Pasha Kostohrys Date: Mon, 16 Mar 2026 13:56:44 +0200 Subject: [PATCH 1/5] "Claude PR Assistant workflow" --- .github/workflows/claude.yml | 50 ++++++++++++++++++++++++++++++++++++ 1 file changed, 50 insertions(+) create mode 100644 .github/workflows/claude.yml diff --git a/.github/workflows/claude.yml b/.github/workflows/claude.yml new file mode 100644 index 0000000000000..d300267f1855c --- /dev/null +++ b/.github/workflows/claude.yml @@ -0,0 +1,50 @@ +name: Claude Code + +on: + issue_comment: + types: [created] + pull_request_review_comment: + types: [created] + issues: + types: [opened, assigned] + pull_request_review: + types: [submitted] + +jobs: + claude: + if: | + (github.event_name == 'issue_comment' && contains(github.event.comment.body, '@claude')) || + (github.event_name == 'pull_request_review_comment' && contains(github.event.comment.body, '@claude')) || + (github.event_name == 'pull_request_review' && contains(github.event.review.body, '@claude')) || + (github.event_name == 'issues' && (contains(github.event.issue.body, '@claude') || contains(github.event.issue.title, '@claude'))) + runs-on: ubuntu-latest + permissions: + contents: read + pull-requests: read + issues: read + id-token: write + actions: read # Required for Claude to read CI results on PRs + steps: + - name: Checkout repository + uses: actions/checkout@v4 + with: + fetch-depth: 1 + + - name: Run Claude Code + id: claude + uses: anthropics/claude-code-action@v1 + with: + claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }} + + # This is an optional setting that allows Claude to read CI results on PRs + additional_permissions: | + actions: read + + # Optional: Give a custom prompt to Claude. If this is not specified, Claude will perform the instructions specified in the comment that tagged it. + # prompt: 'Update the pull request description to include a summary of changes.' + + # Optional: Add claude_args to customize behavior and configuration + # See https://github.com/anthropics/claude-code-action/blob/main/docs/usage.md + # or https://code.claude.com/docs/en/cli-reference for available options + # claude_args: '--allowed-tools Bash(gh pr:*)' + From 00aa164e55e40ff526913dc2cd7bbbde5bf4a60e Mon Sep 17 00:00:00 2001 From: Pasha Kostohrys Date: Mon, 16 Mar 2026 13:56:46 +0200 Subject: [PATCH 2/5] "Claude Code Review workflow" --- .github/workflows/claude-code-review.yml | 44 ++++++++++++++++++++++++ 1 file changed, 44 insertions(+) create mode 100644 .github/workflows/claude-code-review.yml diff --git a/.github/workflows/claude-code-review.yml b/.github/workflows/claude-code-review.yml new file mode 100644 index 0000000000000..b5e8cfd4dc37c --- /dev/null +++ b/.github/workflows/claude-code-review.yml @@ -0,0 +1,44 @@ +name: Claude Code Review + +on: + pull_request: + types: [opened, synchronize, ready_for_review, reopened] + # Optional: Only run on specific file changes + # paths: + # - "src/**/*.ts" + # - "src/**/*.tsx" + # - "src/**/*.js" + # - "src/**/*.jsx" + +jobs: + claude-review: + # Optional: Filter by PR author + # if: | + # github.event.pull_request.user.login == 'external-contributor' || + # github.event.pull_request.user.login == 'new-developer' || + # github.event.pull_request.author_association == 'FIRST_TIME_CONTRIBUTOR' + + runs-on: ubuntu-latest + permissions: + contents: read + pull-requests: read + issues: read + id-token: write + + steps: + - name: Checkout repository + uses: actions/checkout@v4 + with: + fetch-depth: 1 + + - name: Run Claude Code Review + id: claude-review + uses: anthropics/claude-code-action@v1 + with: + claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }} + plugin_marketplaces: 'https://github.com/anthropics/claude-code.git' + plugins: 'code-review@claude-code-plugins' + prompt: '/code-review:code-review ${{ github.repository }}/pull/${{ github.event.pull_request.number }}' + # See https://github.com/anthropics/claude-code-action/blob/main/docs/usage.md + # or https://code.claude.com/docs/en/cli-reference for available options + From 9d66637d359ebc6e0de9e47392ca4dbc538852cd Mon Sep 17 00:00:00 2001 From: pasha Date: Mon, 16 Mar 2026 14:21:58 +0200 Subject: [PATCH 3/5] Enhance PodLogs error handling to track stream opening errors. Added logic to count errors and return the first encountered error if all streams fail when querying previous logs. --- server/application/application.go | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/server/application/application.go b/server/application/application.go index 9d5e96c1aadea..7d724990ce592 100644 --- a/server/application/application.go +++ b/server/application/application.go @@ -1859,6 +1859,8 @@ func (s *Server) PodLogs(q *application.ApplicationPodLogsQuery, ws application. } var streams []chan logEntry + var streamOpenErrCount int + var firstStreamOpenErr error for _, pod := range pods { stream, err := kubeClientset.CoreV1().Pods(pod.Namespace).GetLogs(pod.Name, &corev1.PodLogOptions{ @@ -1870,6 +1872,12 @@ func (s *Server) PodLogs(q *application.ApplicationPodLogsQuery, ws application. TailLines: tailLines, Previous: q.GetPrevious(), }).Stream(ws.Context()) + if err != nil { + streamOpenErrCount++ + if firstStreamOpenErr == nil { + firstStreamOpenErr = err + } + } podName := pod.Name logStream := make(chan logEntry) if err == nil { @@ -1889,6 +1897,10 @@ func (s *Server) PodLogs(q *application.ApplicationPodLogsQuery, ws application. }() } + if q.GetPrevious() && streamOpenErrCount == len(pods) && firstStreamOpenErr != nil { + return status.Error(codes.InvalidArgument, firstStreamOpenErr.Error()) + } + logStream := mergeLogStreams(streams, time.Millisecond*100) sentCount := int64(0) done := make(chan error) From ffb071506d389e53021afb15380e7d126abaade1 Mon Sep 17 00:00:00 2001 From: Pasha Kostohrys Date: Mon, 16 Mar 2026 14:54:23 +0200 Subject: [PATCH 4/5] Update claude.yml --- .github/workflows/claude.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/claude.yml b/.github/workflows/claude.yml index d300267f1855c..1bf05901bf942 100644 --- a/.github/workflows/claude.yml +++ b/.github/workflows/claude.yml @@ -20,7 +20,7 @@ jobs: runs-on: ubuntu-latest permissions: contents: read - pull-requests: read + pull-requests: write issues: read id-token: write actions: read # Required for Claude to read CI results on PRs From c0fbf8f2290e1a2e87d9da2b0012d5415e7ee35d Mon Sep 17 00:00:00 2001 From: pasha Date: Mon, 16 Mar 2026 14:57:25 +0200 Subject: [PATCH 5/5] Fix PodLogs function to ensure log stream is closed properly and add debug print statement for stream closure. --- server/application/application.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/server/application/application.go b/server/application/application.go index 7d724990ce592..059a65215d479 100644 --- a/server/application/application.go +++ b/server/application/application.go @@ -1895,6 +1895,9 @@ func (s *Server) PodLogs(q *application.ApplicationPodLogsQuery, ws application. } close(logStream) }() + + close(logStream) + println("closed log stream") } if q.GetPrevious() && streamOpenErrCount == len(pods) && firstStreamOpenErr != nil {