Add views in test dataset and implement get_view_names for sqlalchemy dialect

Peng Ren · Peng Ren · commit 2e52aaa30d8c · 2026-04-19T10:55:56.000-04:00
diff --git a/pymongosql/__init__.py b/pymongosql/__init__.py
@@ -6,7 +6,7 @@
 if TYPE_CHECKING:
     from .connection import Connection
 
-__version__: str = "0.5.0"
+__version__: str = "0.6.0"
 
 # Globals https://www.python.org/dev/peps/pep-0249/#globals
 apilevel: str = "2.0"
diff --git a/pymongosql/sqlalchemy_mongodb/sqlalchemy_dialect.py b/pymongosql/sqlalchemy_mongodb/sqlalchemy_dialect.py
@@ -300,38 +300,33 @@ def has_table(self, connection, table_name: str, schema: Optional[str] = None, *
         return False
 
     def get_table_names(self, connection, schema: Optional[str] = None, **kwargs) -> List[str]:
-        """Get list of collections (tables)."""
+        """Get list of collections (tables), excluding views."""
         try:
-            # Use MongoDB listCollections command directly
             db_connection = connection.connection
             if hasattr(db_connection, "_client"):
                 if schema:
                     db = db_connection._client[schema]
                 else:
                     db = db_connection.database
 
-                # Use listCollections command
-                return db.list_collection_names()
+                return db.list_collection_names(filter={"type": {"$ne": "view"}})
         except Exception as e:
             _logger.warning(f"Failed to get table names: {e}")
         return []
 
     def get_view_names(self, connection, schema: Optional[str] = None, **kwargs) -> List[str]:
-        """Get list of views.
-
-        MongoDB doesn't have traditional SQL views like relational databases.
-        Return empty list to satisfy SQLAlchemy and tools like Superset.
-
-        Args:
-            connection: Database connection
-            schema: Optional schema/database name
-            **kwargs: Additional arguments
+        """Get list of MongoDB views."""
+        try:
+            db_connection = connection.connection
+            if hasattr(db_connection, "_client"):
+                if schema:
+                    db = db_connection._client[schema]
+                else:
+                    db = db_connection.database
 
-        Returns:
-            Empty list as MongoDB doesn't support SQL views
-        """
-        # MongoDB doesn't have traditional SQL views
-        # Return empty list to avoid NotImplementedError
+                return db.list_collection_names(filter={"type": "view"})
+        except Exception as e:
+            _logger.warning(f"Failed to get view names: {e}")
         return []
 
     def get_columns(self, connection, table_name: str, schema: Optional[str] = None, **kwargs) -> List[Dict[str, Any]]:
diff --git a/tests/data/sensor_readings.json b/tests/data/sensor_readings.json
@@ -0,0 +1,86 @@
+[
+  {
+    "sensor_id": "sensor_01",
+    "timestamp": {"$date": "2024-01-15T08:00:00Z"},
+    "metadata": {"location": "warehouse_A", "type": "temperature"},
+    "temperature": 22.5,
+    "humidity": 45.2
+  },
+  {
+    "sensor_id": "sensor_01",
+    "timestamp": {"$date": "2024-01-15T08:15:00Z"},
+    "metadata": {"location": "warehouse_A", "type": "temperature"},
+    "temperature": 22.8,
+    "humidity": 44.9
+  },
+  {
+    "sensor_id": "sensor_01",
+    "timestamp": {"$date": "2024-01-15T08:30:00Z"},
+    "metadata": {"location": "warehouse_A", "type": "temperature"},
+    "temperature": 23.1,
+    "humidity": 44.5
+  },
+  {
+    "sensor_id": "sensor_02",
+    "timestamp": {"$date": "2024-01-15T08:00:00Z"},
+    "metadata": {"location": "warehouse_B", "type": "temperature"},
+    "temperature": 19.3,
+    "humidity": 52.1
+  },
+  {
+    "sensor_id": "sensor_02",
+    "timestamp": {"$date": "2024-01-15T08:15:00Z"},
+    "metadata": {"location": "warehouse_B", "type": "temperature"},
+    "temperature": 19.5,
+    "humidity": 51.8
+  },
+  {
+    "sensor_id": "sensor_02",
+    "timestamp": {"$date": "2024-01-15T08:30:00Z"},
+    "metadata": {"location": "warehouse_B", "type": "temperature"},
+    "temperature": 19.8,
+    "humidity": 51.3
+  },
+  {
+    "sensor_id": "sensor_03",
+    "timestamp": {"$date": "2024-01-15T08:00:00Z"},
+    "metadata": {"location": "office_1", "type": "environment"},
+    "temperature": 21.0,
+    "humidity": 40.0
+  },
+  {
+    "sensor_id": "sensor_03",
+    "timestamp": {"$date": "2024-01-15T08:15:00Z"},
+    "metadata": {"location": "office_1", "type": "environment"},
+    "temperature": 21.3,
+    "humidity": 39.7
+  },
+  {
+    "sensor_id": "sensor_03",
+    "timestamp": {"$date": "2024-01-15T08:30:00Z"},
+    "metadata": {"location": "office_1", "type": "environment"},
+    "temperature": 21.6,
+    "humidity": 39.4
+  },
+  {
+    "sensor_id": "sensor_01",
+    "timestamp": {"$date": "2024-01-15T09:00:00Z"},
+    "metadata": {"location": "warehouse_A", "type": "temperature"},
+    "temperature": 23.5,
+    "humidity": 43.8
+  },
+  {
+    "sensor_id": "sensor_02",
+    "timestamp": {"$date": "2024-01-15T09:00:00Z"},
+    "metadata": {"location": "warehouse_B", "type": "temperature"},
+    "temperature": 20.1,
+    "humidity": 50.9
+  },
+  {
+    "sensor_id": "sensor_03",
+    "timestamp": {"$date": "2024-01-15T09:00:00Z"},
+    "metadata": {"location": "office_1", "type": "environment"},
+    "temperature": 22.0,
+    "humidity": 38.9
+  }
+]
diff --git a/tests/run_test_server.py b/tests/run_test_server.py
@@ -58,6 +58,9 @@ def load_config():
 if "test_data_file" in config and not TEST_DATA_FILES:
     TEST_DATA_FILES = {"legacy": config["test_data_file"]}
 
+# Time-series collection definitions
+TIMESERIES_COLLECTIONS = config.get("timeseries_collections", {})
+
 
 def check_docker():
     """Check if Docker is available and running"""
@@ -244,6 +247,82 @@ def load_test_data():
     return test_data
 
 
+def _create_views(db):
+    """Create MongoDB views for testing"""
+    views = [
+        {
+            "name": "active_users",
+            "viewOn": "users",
+            "pipeline": [
+                {"$match": {"active": True}},
+                {"$project": {"_id": 1, "name": 1, "email": 1, "age": 1, "balance": 1}},
+            ],
+        },
+        {
+            "name": "completed_orders",
+            "viewOn": "orders",
+            "pipeline": [
+                {"$match": {"status": "completed"}},
+                {
+                    "$project": {
+                        "_id": 1,
+                        "user_id": 1,
+                        "order_date": 1,
+                        "total_amount": 1,
+                        "currency": 1,
+                    }
+                },
+            ],
+        },
+        {
+            "name": "in_stock_products",
+            "viewOn": "products",
+            "pipeline": [
+                {"$match": {"in_stock": True}},
+                {"$project": {"_id": 1, "name": 1, "price": 1, "category": 1, "quantity": 1}},
+            ],
+        },
+        {
+            "name": "orders_with_users",
+            "viewOn": "orders",
+            "pipeline": [
+                {
+                    "$lookup": {
+                        "from": "users",
+                        "localField": "user_id",
+                        "foreignField": "_id",
+                        "as": "user",
+                    }
+                },
+                {"$unwind": "$user"},
+                {
+                    "$project": {
+                        "_id": 1,
+                        "order_date": 1,
+                        "status": 1,
+                        "total_amount": 1,
+                        "currency": 1,
+                        "user_name": "$user.name",
+                        "user_email": "$user.email",
+                    }
+                },
+            ],
+        },
+    ]
+
+    for view in views:
+        # Drop existing view if it exists
+        db[view["name"]].drop()
+        db.command(
+            {
+                "create": view["name"],
+                "viewOn": view["viewOn"],
+                "pipeline": view["pipeline"],
+            }
+        )
+        print(f"  Created view '{view['name']}' on '{view['viewOn']}'")
+
+
 def setup_test_data():
     """Setup test data in MongoDB"""
     print("Setting up test data...")
@@ -273,11 +352,23 @@ def setup_test_data():
                 # Drop existing collection
                 db[collection_name].drop()
 
+                # Create time-series collection if configured
+                if collection_name in TIMESERIES_COLLECTIONS:
+                    ts_opts = TIMESERIES_COLLECTIONS[collection_name]
+                    db.create_collection(
+                        collection_name,
+                        timeseries=ts_opts,
+                    )
+                    print(f"  Created time-series collection '{collection_name}' (timeField={ts_opts['timeField']})")
+
                 # Insert new data
                 db[collection_name].insert_many(test_data[collection_name])
                 count = db[collection_name].count_documents({})
                 print(f"  Inserted {count} {collection_name}")
 
+        # Create MongoDB views
+        _create_views(db)
+
         print("[SUCCESS] Test data setup completed successfully!")
         return True
 
diff --git a/tests/server_config.json b/tests/server_config.json
@@ -25,6 +25,14 @@
         "analytics": "data/analytics.json",
         "departments": "data/departments.json",
         "suppliers": "data/suppliers.json",
-        "user-orders": "data/user-orders.json"
+        "user-orders": "data/user-orders.json",
+        "sensor_readings": "data/sensor_readings.json"
+    },
+    "timeseries_collections": {
+        "sensor_readings": {
+            "timeField": "timestamp",
+            "metaField": "metadata",
+            "granularity": "minutes"
+        }
     }
 }
diff --git a/tests/test_sqlalchemy_dialect.py b/tests/test_sqlalchemy_dialect.py
