Skip to content

Rename ServerDomain -> RPID#641

Merged
abergs merged 2 commits into
mainfrom
rename-serverdomain-rpid
Apr 14, 2026
Merged

Rename ServerDomain -> RPID#641
abergs merged 2 commits into
mainfrom
rename-serverdomain-rpid

Conversation

@abergs

@abergs abergs commented Dec 8, 2025

Copy link
Copy Markdown
Collaborator

This PR renames the configuration properties ServerDomain and ServerName to the more spec aligned RPID and RPName.

This library aims to be close to the spec in naming, and having these two fields be anything different is just confusing.

@abergs
abergs force-pushed the rename-serverdomain-rpid branch from f19efe3 to 0d4d1ce Compare December 8, 2025 18:44
@codecov

codecov Bot commented Dec 8, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 78.63%. Comparing base (2a19063) to head (3772484).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
Src/Fido2.Models/CredentialCreateOptions.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #641      +/-   ##
==========================================
+ Coverage   78.37%   78.63%   +0.25%     
==========================================
  Files          98       98              
  Lines        2539     2546       +7     
  Branches      422      423       +1     
==========================================
+ Hits         1990     2002      +12     
+ Misses        439      434       -5     
  Partials      110      110              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@abergs abergs added this to the Version 5 milestone Dec 8, 2025
Comment thread Src/Fido2.Models/Fido2Configuration.cs
@abergs
abergs merged commit 1830c17 into main Apr 14, 2026
9 checks passed
@abergs
abergs deleted the rename-serverdomain-rpid branch April 14, 2026 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant