Skip to content

Handle the lack of userHandle better in demo#653

Merged
abergs merged 1 commit into
mainfrom
fix-demo-userhandle
Apr 8, 2026
Merged

Handle the lack of userHandle better in demo#653
abergs merged 1 commit into
mainfrom
fix-demo-userhandle

Conversation

@abergs

@abergs abergs commented Apr 8, 2026

Copy link
Copy Markdown
Collaborator

Fix crash in usernameless login demo when authenticator doesn't return a userHandle (non-resident keys) and also guard against null userHandle before wrapping in Uint8Array, which would throw a TypeError

Re-implements #648.

Previously, if the key was not resident, userHandle wouldn't
be null, and an empty string userHandle would be passed.
This would later crash in the controller.
@codecov

codecov Bot commented Apr 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.59%. Comparing base (7f16774) to head (41f7d86).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #653   +/-   ##
=======================================
  Coverage   78.59%   78.59%           
=======================================
  Files          98       98           
  Lines        2542     2542           
  Branches      423      423           
=======================================
  Hits         1998     1998           
  Misses        434      434           
  Partials      110      110           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@abergs
abergs merged commit 48c5634 into main Apr 8, 2026
9 checks passed
@abergs
abergs deleted the fix-demo-userhandle branch April 8, 2026 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant