Skip to content

Demo: Use PublicKeyCredential parse functions instead of converting by hand#654

Merged
abergs merged 1 commit into
passwordless-lib:mainfrom
Edduaardo:demo-use-publickeycredential-api
Apr 13, 2026
Merged

Demo: Use PublicKeyCredential parse functions instead of converting by hand#654
abergs merged 1 commit into
passwordless-lib:mainfrom
Edduaardo:demo-use-publickeycredential-api

Conversation

@Edduaardo

Copy link
Copy Markdown
Contributor

Use PublicKeyCredential functions parseCreationOptionsFromJSON(), parseRequestOptionsFromJSON() and toJSON() to convert between Base64Url and ArrayBuffers instead of doing it by hand, as it is the recommended way now. It also stops using the deprecated extensions property in favor of clientExtensionResults.

https://developer.mozilla.org/en-US/docs/Web/API/PublicKeyCredential/parseCreationOptionsFromJSON_static
https://developer.mozilla.org/en-US/docs/Web/API/PublicKeyCredential/parseRequestOptionsFromJSON_static
https://developer.mozilla.org/en-US/docs/Web/API/PublicKeyCredential/toJSON

@Edduaardo

Copy link
Copy Markdown
Contributor Author

@dotnet-policy-service agree

@codecov

codecov Bot commented Apr 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.62%. Comparing base (40b302c) to head (8784f4c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #654   +/-   ##
=======================================
  Coverage   78.62%   78.62%           
=======================================
  Files          98       98           
  Lines        2545     2545           
  Branches      423      423           
=======================================
  Hits         2001     2001           
  Misses        434      434           
  Partials      110      110           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@abergs
abergs merged commit 5e556bd into passwordless-lib:main Apr 13, 2026
9 checks passed
@abergs

abergs commented Apr 13, 2026

Copy link
Copy Markdown
Collaborator

Thank you for the contribution @Edduaardo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants