Skip to content

Fix download sizes and time estimates according to ISO #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ericek111 wants to merge 1 commit into
base: bundlephobia
Choose a base branch
from
Open

Fix download sizes and time estimates according to ISO #552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pages/package/[...packageString]/ResultPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,7 @@ class ResultPage extends PureComponent {
label="Emerging 4G"
infoText={`Download Speed: ⬇️ ${
DownloadSpeed.FOUR_G / 1000
} mB/s`}
} MB/s`}
/>
</div>
</div>
Expand Down
8 changes: 4 additions & 4 deletions utils/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ const formatSize = value => {
size = value
} else if (Math.log10(value) < 6) {
unit = 'kB'
size = value / 1024
size = value / 1000
} else {
unit = 'MB'
size = value / 1024 / 1024
size = value / 1000 / 1000
}

return { unit, size }
Expand Down Expand Up @@ -49,8 +49,8 @@ const DownloadSpeed = {
}
const getTimeFromSize = sizeInBytes => {
return {
threeG: sizeInBytes / 1024 / DownloadSpeed.THREE_G,
fourG: sizeInBytes / 1024 / DownloadSpeed.FOUR_G,
threeG: sizeInBytes / 1000 / DownloadSpeed.THREE_G,
fourG: sizeInBytes / 1000 / DownloadSpeed.FOUR_G,
}
}

Expand Down