Modernize client/components#725
Open
darasus wants to merge 1 commit into
Open
Conversation
darasus
force-pushed
the
modernize-client-components
branch
from
010a7c5 to
c5aa498
Compare
pastelsky
requested changes
Nov 22, 2022
| > | ||
|
|
||
| function TreemapSquare({ | ||
| export function TreemapSquare({ |
Owner
There was a problem hiding this comment.
Why are we converting default exports to named once, that seems rather un-necessary.
| getSuggestionIssueUrl = () => { | ||
| export function SimilarPackageCard({ | ||
| category, | ||
| ...props |
Owner
|
@darasus do you plan on continuing working on this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.