feat: Add lz4 compression to array_encodings#579
Conversation
|
@dionhaefner @nmheim Let me know if this is what you meant by testing compression in tesseract? |
|
That's a good start, thanks @angela-ko ! As next step, please add minimal, meaningful end-to-end tests that cover this functionality - which I expect are going to fail because I do see some issues with how the new lz4 dependency is added :) Once everything is passing end-to-end I'll have a closer look at the design choices here. |
|
And please outline your rationale for choosing lz4 specifically as part of the PR body. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #579 +/- ##
==========================================
- Coverage 77.12% 77.04% -0.08%
==========================================
Files 32 32
Lines 4489 4540 +51
Branches 738 751 +13
==========================================
+ Hits 3462 3498 +36
- Misses 724 735 +11
- Partials 303 307 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Benchmark ResultsBenchmarks use a no-op Tesseract to measure pure framework overhead. 🚀 1 faster, Notable changes
Full results
|
56294af to
17fb949
Compare
8b4bff9 to
50ee165
Compare
…ssion sie if compression is set
8310d77 to
dc6a43b
Compare
Relevant issue or PR
To be done prior to implementing in pasteur-types
Changes are basically identical to the changes here
https://github.com/pasteurlabs/pasteur-types/pull/358/changes
Following the design doc here - chose to start with lz4 as the minimal dependency option for compression, and we can add in more optional compression types once it's working
https://pasteurisi.atlassian.net/wiki/spaces/~71202060d9f9d7be6c427dafac7d77e930e293/pages/1191247903/Compression+-+Design+Options
Description of changes
Testing done
Unit testing