feat: add tesseract serve --skip-health-check argument#596
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #596 +/- ##
==========================================
+ Coverage 77.07% 77.08% +0.01%
==========================================
Files 32 32
Lines 4488 4491 +3
Branches 738 739 +1
==========================================
+ Hits 3459 3462 +3
- Misses 726 727 +1
+ Partials 303 302 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Benchmark ResultsBenchmarks use a no-op Tesseract to measure pure framework overhead. 🚀 0 faster, Notable changes
Full results
|
jpbrodrick89
left a comment
There was a problem hiding this comment.
LGTM, for these long startup Tesseracts do we have any recommendation users for the best way to probe when the Tesseract is ready? Do they just need to manually run health/another endpoint call until they don't get a connection error? Is it easy to setup a feature such that all Tesseracts write to their logs when ready or is that something the Tesseract create needs to manually code in?
Relevant issue or PR
n/a
Description of changes
Sometimes Tesseracts are expected to take a long time to start up, e.g. when JIT compiling or loading model weights. In this case, health checks can time out even though nothing's wrong with the Tesseract per se. This introduces a
skip_health_checkarg toserveproviding users with a workaround.Testing done
CI