Skip to content

feat: new condensed two-column layout#129

Open
dionhaefner wants to merge 1 commit into
mainfrom
dion/better-layout
Open

feat: new condensed two-column layout#129
dionhaefner wants to merge 1 commit into
mainfrom
dion/better-layout

Conversation

@dionhaefner
Copy link
Copy Markdown
Contributor

@dionhaefner dionhaefner commented Apr 13, 2026

Relevant issue or PR

n/a

Description of changes

I'll let those screenshots speak for themselves:

Screenshot 2026-04-14 at 12 09 40 Screenshot 2026-04-14 at 13 08 37

Testing done

👀

@dionhaefner dionhaefner marked this pull request as ready for review April 14, 2026 11:09
Copy link
Copy Markdown
Collaborator

@jacanchaplais jacanchaplais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how much I'm into this. Might be helpful to speak for it more than just the screenshots? 😂

From what I can tell in the source, you've switched to a two column layout, with data input on the left 40%, and display on the right 60%. Then for the JSON displays, you've put the download buttons inline by creating two subcolumns, 80% for the preview and 20% for the download button.

Since you've only edited the Jinja template, that'd mean there's no opt-out here.

I get the desire for this, it feels like the horizontal real-estate is going to waste with one column. However,

  1. It looks a bit busy for my taste.
  2. The horizontal real-estate for the figures is reduced.
  3. It seems likely that folks might create lots of UDFs. Judging from the screenshots, you'd quickly scroll past the convenient input-output side-by-side, and then be back to effectively a single-column layout, where the figures are smaller and off-centre.

I think this could be nice, but I'd want to toggle it, and I think we need to give some thought to scaling with content (and perhaps screen-size?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants