Merge pull request #329 from patchlevel/3.17.x-merge-up-into-3.18.x_zLycyEQB

Merge release 3.17.1 into 3.18.x

Author: DanielBadura

src/CommandBus/SymfonyCommandBus.php

@@ -8,6 +8,8 @@
 use Symfony\Component\Messenger\Exception\HandlerFailedException;
 use Symfony\Component\Messenger\MessageBusInterface;
 
+use function array_values;
+
 final class SymfonyCommandBus implements CommandBus
 {
     public function __construct(
@@ -20,7 +22,7 @@ public function dispatch(object $command): void
         try {
             $this->messageBus->dispatch($command);
         } catch (HandlerFailedException $e) {
-            throw $e->getWrappedExceptions(null, true)[0] ?? $e;
+            throw array_values($e->getWrappedExceptions(null, true))[0] ?? $e;
         }
     }
 }

tests/Unit/CommandBus/SymfonyCommandBusTest.php

@@ -0,0 +1,125 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Patchlevel\EventSourcingBundle\Tests\Unit\CommandBus;
+
+use Patchlevel\EventSourcing\Aggregate\CustomId;
+use Patchlevel\EventSourcingBundle\CommandBus\SymfonyCommandBus;
+use Patchlevel\EventSourcingBundle\Tests\Fixtures\CreateProfile;
+use PHPUnit\Framework\TestCase;
+use RuntimeException;
+use Symfony\Component\Messenger\Envelope;
+use Symfony\Component\Messenger\Exception\HandlerFailedException;
+use Symfony\Component\Messenger\MessageBus;
+use Symfony\Component\Messenger\Middleware\MiddlewareInterface;
+use Symfony\Component\Messenger\Middleware\StackInterface;
+
+/** @covers \Patchlevel\EventSourcingBundle\EventBus\SymfonyEventBus */
+final class SymfonyCommandBusTest extends TestCase
+{
+    public function testDispatch(): void
+    {
+        $command = new CreateProfile(CustomId::fromString('1'));
+
+        $middleware = new class implements MiddlewareInterface
+        {
+            public object|null $command = null;
+
+            public function handle(Envelope $envelope, StackInterface $stack): Envelope
+            {
+                $this->command = $envelope->getMessage();
+
+                return $envelope;
+            }
+        };
+        $messageBus = new MessageBus([$middleware]);
+
+        $commandBus = new SymfonyCommandBus($messageBus);
+        $commandBus->dispatch($command);
+
+        self::assertNotNull($middleware->command);
+        self::assertSame($command, $middleware->command);
+    }
+
+    public function testException(): void
+    {
+        $command = new CreateProfile(CustomId::fromString('1'));
+
+        $middleware = new class implements MiddlewareInterface
+        {
+            public object|null $command = null;
+
+            public function handle(Envelope $envelope, StackInterface $stack): Envelope
+            {
+                $this->command = $envelope->getMessage();
+
+                throw new RuntimeException('test');
+            }
+        };
+        $messageBus = new MessageBus([$middleware]);
+
+        $this->expectException(RuntimeException::class);
+        $this->expectExceptionMessageMatches('/^test$/');
+
+        $commandBus = new SymfonyCommandBus($messageBus);
+        $commandBus->dispatch($command);
+
+        self::assertNotNull($middleware->command);
+        self::assertSame($command, $middleware->command);
+    }
+
+    public function testRecursiveException(): void
+    {
+        $command = new CreateProfile(CustomId::fromString('1'));
+
+        $middleware = new class implements MiddlewareInterface
+        {
+            public object|null $command = null;
+
+            public function handle(Envelope $envelope, StackInterface $stack): Envelope
+            {
+                $this->command = $envelope->getMessage();
+
+                throw new HandlerFailedException($envelope, [new RuntimeException('test')]);
+            }
+        };
+        $messageBus = new MessageBus([$middleware]);
+
+        $this->expectException(RuntimeException::class);
+        $this->expectExceptionMessageMatches('/^test$/');
+
+        $commandBus = new SymfonyCommandBus($messageBus);
+        $commandBus->dispatch($command);
+
+        self::assertNotNull($middleware->command);
+        self::assertSame($command, $middleware->command);
+    }
+
+    public function testRecursiveExceptionStringKey(): void
+    {
+        $command = new CreateProfile(CustomId::fromString('1'));
+
+        $middleware = new class implements MiddlewareInterface
+        {
+            public object|null $command = null;
+
+            public function handle(Envelope $envelope, StackInterface $stack): Envelope
+            {
+                $this->command = $envelope->getMessage();
+
+                throw new HandlerFailedException($envelope, ['controller-class' => new RuntimeException('test')]);
+            }
+        };
+        $messageBus = new MessageBus([$middleware]);
+
+        $this->expectException(RuntimeException::class);
+        $this->expectExceptionMessageMatches('/^test$/');
+
+        $commandBus = new SymfonyCommandBus($messageBus);
+        $commandBus->dispatch($command);
+
+        self::assertNotNull($middleware->command);
+        self::assertSame($command, $middleware->command);
+    }
+}