update upgrade docs & remove unused noRetry factory

Author: DavidBadura

docs/mkdocs.yml

@@ -113,7 +113,7 @@ nav:
     - CLI: cli.md
   - Supported Versions: supported-versions.md
   - Our BC Promise: our-backward-compatibility-promise.md
-  - Upgrade from 2.x: UPGRADE-3.0.md
+  - Upgrade from 3.x: UPGRADE-4.0.md
   - Links:
     - Blog: https://patchlevel.de/blog
     - Symfony Bundle: https://patchlevel.github.io/event-sourcing-bundle-docs/latest/

docs/pages/UPGRADE-4.0.md

@@ -2,6 +2,53 @@
 
 ## Subscription
 
-* The constructor of the `SubscriptionEngine` class has been changed
-* * Instead of passing a `Store` instance, you now need to pass a `MessageLoader` instance.
-* * Instead of passing a `RetryStrategy` instance, you now need to pass a `RetryStrategyRepository` instance.
+The constructor of the `DefaultSubscriptionEngine` class has been changed.
+* Instead of passing a `Store` instance, you now need to pass a `MessageLoader` instance.
+* Instead of passing a `RetryStrategy` instance, you now need to pass a `RetryStrategyRepository` instance.
+
+before:
+
+```php
+use Patchlevel\EventSourcing\Store\Store;
+use Patchlevel\EventSourcing\Subscription\Engine\DefaultSubscriptionEngine;
+use Patchlevel\EventSourcing\Subscription\RetryStrategy\RetryStrategy;
+use Patchlevel\EventSourcing\Subscription\Store\DoctrineSubscriptionStore;
+use Patchlevel\EventSourcing\Subscription\Subscriber\MetadataSubscriberAccessorRepository;
+
+/**
+ * @var Store $store
+ * @var DoctrineSubscriptionStore $subscriptionStore
+ * @var MetadataSubscriberAccessorRepository $subscriberAccessorRepository
+ * @var RetryStrategy $retryStrategy
+ */
+$subscriptionEngine = new DefaultSubscriptionEngine(
+    $messageLoader,
+    $subscriptionStore,
+    $subscriberAccessorRepository,
+    $retryStrategy,
+);
+```
+after:
+
+```php
+use Patchlevel\EventSourcing\Store\Store;
+use Patchlevel\EventSourcing\Subscription\Engine\DefaultSubscriptionEngine;
+use Patchlevel\EventSourcing\Subscription\Engine\StoreMessageLoader;
+use Patchlevel\EventSourcing\Subscription\RetryStrategy\RetryStrategy;
+use Patchlevel\EventSourcing\Subscription\RetryStrategy\RetryStrategyRepository;
+use Patchlevel\EventSourcing\Subscription\Store\DoctrineSubscriptionStore;
+use Patchlevel\EventSourcing\Subscription\Subscriber\MetadataSubscriberAccessorRepository;
+
+/**
+ * @var Store $store
+ * @var DoctrineSubscriptionStore $subscriptionStore
+ * @var MetadataSubscriberAccessorRepository $subscriberAccessorRepository
+ * @var RetryStrategy $retryStrategy
+ */
+$subscriptionEngine = new DefaultSubscriptionEngine(
+    new StoreMessageLoader($store),
+    $subscriptionStore,
+    $subscriberAccessorRepository,
+    RetryStrategyRepository::withDefault($retryStrategy),
+);
+```

src/Subscription/RetryStrategy/RetryStrategyRepository.php

@@ -36,14 +36,4 @@ public static function withDefault(RetryStrategy $retryStrategy): self
             self::DEFAULT_STRATEGY_NAME,
         );
     }
-
-    public static function noRetry(): self
-    {
-        return new self(
-            [
-                self::DEFAULT_STRATEGY_NAME => new NoRetryStrategy(),
-            ],
-            self::DEFAULT_STRATEGY_NAME,
-        );
-    }
 }