Merge pull request #832 from patchlevel/phpat-layer

Add layer tests with `phpat` based on `deptrac` layers, remove `deptrac`

Author: DanielBadura

.github/workflows/deptrac.yml

@@ -8,6 +8,5 @@ infection.log
 .phpbench/
 infection.html
 *.sqlite3
-.deptrac.cache
 docs_php/
 docs/.cache

.gitignore

@@ -51,14 +51,6 @@ infection: vendor
 infection-diff: vendor                                                          ## run infection on differences
 	php -d memory_limit=312M vendor/bin/infection --threads=max --git-diff-lines --git-diff-base=origin/HEAD --ignore-msi-with-no-mutations --only-covered --min-msi=80 --min-covered-msi=95
 
-.PHONY: deptrac
-deptrac: vendor-tools                                                           ## run deptrac
-	cd tools && ./vendor/bin/deptrac -c ../deptrac.yaml
-
-.PHONY: deptrac-baseline
-deptrac-baseline: vendor-tools                                                 ## run deptrac and update baseline
-	cd tools && ./vendor/bin/deptrac -c ../deptrac.yaml --formatter=baseline --output=../deptrac-baseline.yaml
-
 .PHONY: static
 static: phpstan cs                                              			 ## run static analyser
 

Makefile

@@ -1,5 +1,35 @@
 parameters:
 	ignoreErrors:
+		-
+			message: '#^Patchlevel\\EventSourcing\\Aggregate\\AggregateRootId should not depend on Patchlevel\\EventSourcing\\Serializer\\Normalizer\\IdNormalizer$#'
+			identifier: phpat.testAggregateCanOnlyDependOnAllowedLayers
+			count: 1
+			path: src/Aggregate/AggregateRootId.php
+
+		-
+			message: '#^Patchlevel\\EventSourcing\\Attribute\\Processor should not depend on Patchlevel\\EventSourcing\\Subscription\\RunMode$#'
+			identifier: phpat.testAttributeCanOnlyDependOnAllowedLayers
+			count: 2
+			path: src/Attribute/Processor.php
+
+		-
+			message: '#^Patchlevel\\EventSourcing\\Attribute\\Projector should not depend on Patchlevel\\EventSourcing\\Subscription\\RunMode$#'
+			identifier: phpat.testAttributeCanOnlyDependOnAllowedLayers
+			count: 2
+			path: src/Attribute/Projector.php
+
+		-
+			message: '#^Patchlevel\\EventSourcing\\Attribute\\SharedApplyContext should not depend on Patchlevel\\EventSourcing\\Aggregate\\AggregateRoot$#'
+			identifier: phpat.testAttributeCanOnlyDependOnAllowedLayers
+			count: 1
+			path: src/Attribute/SharedApplyContext.php
+
+		-
+			message: '#^Patchlevel\\EventSourcing\\Attribute\\Subscriber should not depend on Patchlevel\\EventSourcing\\Subscription\\RunMode$#'
+			identifier: phpat.testAttributeCanOnlyDependOnAllowedLayers
+			count: 1
+			path: src/Attribute/Subscriber.php
+
 		-
 			message: '#^Cannot unset offset ''url'' on array\{application_name\?\: string, charset\?\: string, defaultTableOptions\?\: array\<string, mixed\>, driver\?\: ''ibm_db2''\|''mysqli''\|''oci8''\|''pdo_mysql''\|''pdo_oci''\|''pdo_pgsql''\|''pdo_sqlite''\|''pdo_sqlsrv''\|''pgsql''\|''sqlite3''\|''sqlsrv'', driverClass\?\: class\-string\<Doctrine\\DBAL\\Driver\>, driverOptions\?\: array\<mixed\>, host\?\: string, keepReplica\?\: bool, \.\.\.\}\.$#'
 			identifier: unset.offset
@@ -96,6 +126,12 @@ parameters:
 			count: 1
 			path: src/Store/Criteria/StreamCriterion.php
 
+		-
+			message: '#^Patchlevel\\EventSourcing\\Store\\DoctrineDbalStore should not depend on Patchlevel\\EventSourcing\\Aggregate\\AggregateHeader$#'
+			identifier: phpat.testStoreCanOnlyDependOnAllowedLayers
+			count: 2
+			path: src/Store/DoctrineDbalStore.php
+
 		-
 			message: '#^Method Patchlevel\\EventSourcing\\Store\\DoctrineDbalStoreStream\:\:current\(\) never returns null so it can be removed from the return type\.$#'
 			identifier: return.unusedType
@@ -114,12 +150,36 @@ parameters:
 			count: 1
 			path: src/Store/DoctrineDbalStoreStream.php
 
+		-
+			message: '#^Patchlevel\\EventSourcing\\Store\\DoctrineDbalStoreStream should not depend on Patchlevel\\EventSourcing\\Aggregate\\AggregateHeader$#'
+			identifier: phpat.testStoreCanOnlyDependOnAllowedLayers
+			count: 1
+			path: src/Store/DoctrineDbalStoreStream.php
+
 		-
 			message: '#^Ternary operator condition is always true\.$#'
 			identifier: ternary.alwaysTrue
 			count: 1
 			path: src/Store/DoctrineDbalStoreStream.php
 
+		-
+			message: '#^Patchlevel\\EventSourcing\\Store\\InMemoryStore should not depend on Patchlevel\\EventSourcing\\Aggregate\\AggregateHeader$#'
+			identifier: phpat.testStoreCanOnlyDependOnAllowedLayers
+			count: 5
+			path: src/Store/InMemoryStore.php
+
+		-
+			message: '#^Patchlevel\\EventSourcing\\Store\\InMemoryStore should not depend on Patchlevel\\EventSourcing\\Metadata\\Event\\EventRegistry$#'
+			identifier: phpat.testStoreCanOnlyDependOnAllowedLayers
+			count: 1
+			path: src/Store/InMemoryStore.php
+
+		-
+			message: '#^Patchlevel\\EventSourcing\\Store\\MissingEventRegistry should not depend on Patchlevel\\EventSourcing\\Metadata\\Event\\EventRegistry$#'
+			identifier: phpat.testStoreCanOnlyDependOnAllowedLayers
+			count: 1
+			path: src/Store/MissingEventRegistry.php
+
 		-
 			message: '#^Method Patchlevel\\EventSourcing\\Store\\StreamDoctrineDbalStoreStream\:\:current\(\) never returns null so it can be removed from the return type\.$#'
 			identifier: return.unusedType

deptrac-baseline.yaml

@@ -18,3 +18,8 @@ services:
 		class: Patchlevel\EventSourcing\Tests\Architecture\FinalClassesTest
 		tags:
 			- phpat.test
+
+	-
+		class: Patchlevel\EventSourcing\Tests\Architecture\LayerDependenciesTest
+		tags:
+			- phpat.test