fix phpstan

Author: DavidBadura

phpstan-baseline.neon

@@ -102,6 +102,12 @@ parameters:
 			count: 1
 			path: src/Store/TaggableDoctrineDbalStore.php
 
+		-
+			message: '#^Parameter \#1 \$command of callable Patchlevel\\EventSourcing\\Subscription\\Engine\\Handler\\BootHandler\|Patchlevel\\EventSourcing\\Subscription\\Engine\\Handler\\PauseHandler\|Patchlevel\\EventSourcing\\Subscription\\Engine\\Handler\\ReactivateHandler\|Patchlevel\\EventSourcing\\Subscription\\Engine\\Handler\\RefreshHandler\|Patchlevel\\EventSourcing\\Subscription\\Engine\\Handler\\RemoveHandler\|Patchlevel\\EventSourcing\\Subscription\\Engine\\Handler\\RunHandler\|Patchlevel\\EventSourcing\\Subscription\\Engine\\Handler\\SetupHandler\|Patchlevel\\EventSourcing\\Subscription\\Engine\\Handler\\TeardownHandler expects Patchlevel\\EventSourcing\\Subscription\\Engine\\Command\\Boot\|Patchlevel\\EventSourcing\\Subscription\\Engine\\Command\\Pause\|Patchlevel\\EventSourcing\\Subscription\\Engine\\Command\\Reactivate\|Patchlevel\\EventSourcing\\Subscription\\Engine\\Command\\Refresh\|Patchlevel\\EventSourcing\\Subscription\\Engine\\Command\\Remove\|Patchlevel\\EventSourcing\\Subscription\\Engine\\Command\\Run\|Patchlevel\\EventSourcing\\Subscription\\Engine\\Command\\Setup\|Patchlevel\\EventSourcing\\Subscription\\Engine\\Command\\Teardown, Patchlevel\\EventSourcing\\Subscription\\Engine\\Command\\Command given\.$#'
+			identifier: argument.type
+			count: 1
+			path: src/Subscription/Engine/NextSubscriptionEngine.php
+
 		-
 			message: '#^Parameter \#1 \$eventClass of method Patchlevel\\EventSourcing\\Metadata\\Event\\EventRegistry\:\:eventName\(\) expects class\-string, string given\.$#'
 			identifier: argument.type

src/Subscription/Engine/Handler/RunHandler.php

@@ -16,7 +16,6 @@
 use Patchlevel\EventSourcing\Subscription\RunMode;
 use Patchlevel\EventSourcing\Subscription\Status;
 use Patchlevel\EventSourcing\Subscription\Store\SubscriptionCriteria;
-use Patchlevel\EventSourcing\Subscription\Subscriber\SubscriberAccessorRepository;
 use Psr\Log\LoggerInterface;
 use Symfony\Component\EventDispatcher\EventDispatcherInterface;
 
@@ -34,7 +33,6 @@ final class RunHandler implements Handler
     public function __construct(
         private readonly MessageLoader $messageLoader,
         private readonly SubscriptionManager $subscriptionManager,
-        private readonly SubscriberAccessorRepository $subscriberRepository,
         private readonly MessageProcessor $messageProcessor,
         private readonly EventDispatcherInterface $eventDispatcher,
         private readonly LoggerInterface|null $logger = null,

src/Subscription/Engine/LegacyWrapperSubscriptionEngine.php

@@ -19,6 +19,8 @@
 use Patchlevel\EventSourcing\Subscription\Subscription;
 use Psr\Log\LoggerInterface;
 
+use function assert;
+
 final class LegacyWrapperSubscriptionEngine implements SubscriptionEngine, CanRefreshSubscriptions
 {
     private readonly NextSubscriptionEngine $engine;
@@ -58,11 +60,15 @@ public function boot(
     ): ProcessedResult {
         $criteria ??= new SubscriptionEngineCriteria();
 
-        return $this->engine->run(new Boot(
+        $result = $this->engine->run(new Boot(
             $criteria->ids,
             $criteria->groups,
             $limit,
         ));
+
+        assert($result instanceof ProcessedResult);
+
+        return $result;
     }
 
     public function run(
@@ -71,11 +77,15 @@ public function run(
     ): ProcessedResult {
         $criteria ??= new SubscriptionEngineCriteria();
 
-        return $this->engine->run(new Run(
+        $result = $this->engine->run(new Run(
             $criteria->ids,
             $criteria->groups,
             $limit,
         ));
+
+        assert($result instanceof ProcessedResult);
+
+        return $result;
     }
 
     public function teardown(SubscriptionEngineCriteria|null $criteria = null): Result

src/Subscription/Engine/NextSubscriptionEngine.php

@@ -118,7 +118,6 @@ public function __construct(
             Run::class => new RunHandler(
                 $this->messageLoader,
                 $this->subscriptionManager,
-                $this->subscriberRepository,
                 $messageProcessor,
                 $this->eventDispatcher,
                 $this->logger,

tests/Architecture/FinalClassesTest.php

@@ -5,6 +5,7 @@
 namespace Patchlevel\EventSourcing\Tests\Architecture;
 
 use Patchlevel\EventSourcing\Attribute\Subscriber;
+use Patchlevel\EventSourcing\Subscription\Engine\Result;
 use PHPat\Selector\Selector;
 use PHPat\Test\Builder\Rule;
 use PHPat\Test\PHPat;
@@ -20,6 +21,7 @@ public function testFinalClasses(): Rule
                     Selector::NOT(Selector::isAbstract()),
                     Selector::NOT(Selector::isInterface()),
                     Selector::NOT(Selector::classname(Subscriber::class)),
+                    Selector::NOT(Selector::classname(Result::class)),
                 ),
             )
             ->shouldBeFinal();