Skip to content

cleanup subscription engine constructor#753

Merged
DavidBadura merged 2 commits into
4.0.xfrom
cleanup-subscription-engine-constructor
Jul 2, 2025
Merged

cleanup subscription engine constructor#753
DavidBadura merged 2 commits into
4.0.xfrom
cleanup-subscription-engine-constructor

Conversation

@DavidBadura

@DavidBadura DavidBadura commented Jul 2, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

remove deprecated constructor parameters in subscription engine

@DavidBadura DavidBadura added this to the 4.0.0 milestone Jul 2, 2025
@DavidBadura
DavidBadura requested a review from DanielBadura July 2, 2025 11:38
@github-actions

github-actions Bot commented Jul 2, 2025 •
edited
Loading

Copy link
Copy Markdown

Hello 👋

here is the most recent benchmark result: 

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                         | time (kde mode)                                     | memory                                     |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                 | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000Events () | 4.305ms (±0.00%)   | 4.877ms (±0.00%)   | -11.74%   | 37.651mb        | 38.184mb   | -1.40%      |
| benchSave10000Events () | 335.230ms (±0.00%) | 352.186ms (±0.00%) | -4.81%    | 37.723mb        | 37.724mb   | -0.00%      |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SimpleSetupStreamStoreBench
===========================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 1.009ms (±0.00%)   | 994.200μs (±0.00%) | +1.47%    | 34.458mb        | 34.458mb   | 0.00%       |
| benchLoad10000Events ()                | 56.763ms (±0.00%)  | 58.863ms (±0.00%)  | -3.57%    | 34.458mb        | 34.458mb   | 0.00%       |
| benchSave1Event ()                     | 1.161ms (±0.00%)   | 1.067ms (±0.00%)   | +8.82%    | 34.458mb        | 34.458mb   | 0.00%       |
| benchSave10000Events ()                | 283.847ms (±0.00%) | 306.904ms (±0.00%) | -7.51%    | 34.458mb        | 34.458mb   | 0.00%       |
| benchSave10000Aggregates ()            | 8.839s (±0.00%)    | 8.834s (±0.00%)    | +0.05%    | 34.458mb        | 34.458mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 5.049s (±0.00%)    | 5.070s (±0.00%)    | -0.41%    | 34.458mb        | 34.458mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBench
=======================

+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                               | memory                                     |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>  | Tag: base       | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 3.190s (±0.00%) | 3.196s (±0.00%) | -0.18%    | 46.961mb        | 46.961mb   | 0.00%       |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+

SimpleSetupBench
================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 958.600μs (±0.00%) | 958.200μs (±0.00%) | +0.04%    | 34.344mb        | 34.344mb   | 0.00%       |
| benchLoad10000Events ()                | 51.537ms (±0.00%)  | 51.942ms (±0.00%)  | -0.78%    | 34.344mb        | 34.344mb   | 0.00%       |
| benchSave1Event ()                     | 1.009ms (±0.00%)   | 923.500μs (±0.00%) | +9.25%    | 34.344mb        | 34.344mb   | 0.00%       |
| benchSave10000Events ()                | 215.001ms (±0.00%) | 214.434ms (±0.00%) | +0.26%    | 34.344mb        | 34.344mb   | 0.00%       |
| benchSave10000Aggregates ()            | 8.392s (±0.00%)    | 8.707s (±0.00%)    | -3.62%    | 34.344mb        | 34.344mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 4.840s (±0.00%)    | 4.860s (±0.00%)    | -0.42%    | 34.344mb        | 34.344mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBatchBench
============================

+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                                   | memory                                     |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>    | Tag: base         | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 76.566ms (±0.00%) | 74.200ms (±0.00%) | +3.19%    | 34.813mb        | 34.813mb   | 0.00%       |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+

SnapshotsBench
==============

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000EventsMissingSnapshot () | 52.374ms (±0.00%)  | 51.466ms (±0.00%)  | +1.76%    | 34.419mb        | 34.419mb   | 0.00%       |
| benchLoad10000Events ()                | 877.700μs (±0.00%) | 884.300μs (±0.00%) | -0.75%    | 34.418mb        | 34.418mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

PersonalDataBench
=================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 883.800μs (±0.00%) | 886.500μs (±0.00%) | -0.30%    | 35.548mb        | 35.548mb   | 0.00%       |
| benchLoad10000Events ()                | 94.104ms (±0.00%)  | 93.655ms (±0.00%)  | +0.48%    | 35.548mb        | 35.548mb   | 0.00%       |
| benchSave1Event ()                     | 1.594ms (±0.00%)   | 1.524ms (±0.00%)   | +4.59%    | 35.548mb        | 35.548mb   | 0.00%       |
| benchSave10000Events ()                | 253.208ms (±0.00%) | 250.674ms (±0.00%) | +1.01%    | 35.550mb        | 35.550mb   | 0.00%       |
| benchSave10000Aggregates ()            | 12.559s (±0.00%)   | 12.667s (±0.00%)   | -0.85%    | 35.548mb        | 35.548mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 9.009s (±0.00%)    | 9.061s (±0.00%)    | -0.57%    | 36.050mb        | 36.050mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

This comment gets update everytime a new commit comes in!

DanielBadura
DanielBadura approved these changes Jul 2, 2025
View reviewed changes
Comment thread docs/pages/UPGRADE-4.0.md Outdated
Comment thread src/Subscription/RetryStrategy/RetryStrategyRepository.php Outdated
@DavidBadura
DavidBadura force-pushed the cleanup-subscription-engine-constructor branch from a49f4c7 to 7283d26 Compare July 2, 2025 13:52
@DavidBadura
DavidBadura merged commit b300cc2 into 4.0.x Jul 2, 2025
39 of 40 checks passed
@DavidBadura
DavidBadura deleted the cleanup-subscription-engine-constructor branch July 2, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DanielBadura DanielBadura DanielBadura approved these changes

Assignees

No one assigned

Labels

BC-Break

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@DavidBadura @DanielBadura