Skip to content

Remove deprecated DoctrineDbalStore in favor of StreamDoctrineDbalStore#758

Merged
DavidBadura merged 2 commits into
4.0.xfrom
remove-legacy-store
Jul 23, 2025
Merged

Remove deprecated DoctrineDbalStore in favor of StreamDoctrineDbalStore#758
DavidBadura merged 2 commits into
4.0.xfrom
remove-legacy-store

Conversation

@DavidBadura

@DavidBadura DavidBadura commented Jul 17, 2025

Copy link
Copy Markdown
Member

The following classes have been removed:

  • Patchlevel\EventSourcing\Aggregate\AggregateHeader
  • Patchlevel\EventSourcing\Message\Translator\AggregateToStreamHeaderTranslator
  • Patchlevel\EventSourcing\Store\Criteria\AggregateNameCriterion
  • Patchlevel\EventSourcing\Store\Criteria\AggregateIdCriterion
  • Patchlevel\EventSourcing\Store\DoctrineDbalStore
  • Patchlevel\EventSourcing\Store\DoctrineDbalStoreStream
  • Patchlevel\EventSourcing\Store\ReadOnlyStore

@DavidBadura DavidBadura added this to the 4.0.0 milestone Jul 17, 2025
@DavidBadura
DavidBadura requested a review from DanielBadura July 17, 2025 07:42
@DavidBadura
DavidBadura force-pushed the remove-legacy-store branch from f997318 to 987c622 Compare July 17, 2025 07:44
@github-actions

github-actions Bot commented Jul 17, 2025

Copy link
Copy Markdown

Hello 👋

here is the most recent benchmark result:

PersonalDataBench
=================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 967.400μs (±0.00%) | 939.300μs (±0.00%) | +2.99%    | 35.764mb        | 35.548mb   | +0.61%      |
| benchLoad10000Events ()                | 107.464ms (±0.00%) | 95.355ms (±0.00%)  | +12.70%   | 35.764mb        | 35.548mb   | +0.61%      |
| benchSave1Event ()                     | 1.593ms (±0.00%)   | 1.440ms (±0.00%)   | +10.62%   | 35.764mb        | 35.548mb   | +0.61%      |
| benchSave10000Events ()                | 367.359ms (±0.00%) | 266.253ms (±0.00%) | +37.97%   | 35.765mb        | 35.550mb   | +0.61%      |
| benchSave10000Aggregates ()            | 12.108s (±0.00%)   | 11.712s (±0.00%)   | +3.38%    | 35.764mb        | 35.548mb   | +0.61%      |
| benchSave10000AggregatesTransaction () | 9.417s (±0.00%)    | 9.119s (±0.00%)    | +3.27%    | 36.051mb        | 36.050mb   | +0.00%      |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SnapshotsBench
==============

+----------------------------------------+-------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                    | memory                                     |
+----------------------------------------+-------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>    | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+-------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000EventsMissingSnapshot () | 68.637ms (±0.00%) | 62.857ms (±0.00%)  | +9.20%    | 35.166mb        | 35.008mb   | +0.45%      |
| benchLoad10000Events ()                | 1.016ms (±0.00%)  | 994.800μs (±0.00%) | +2.12%    | 35.166mb        | 35.008mb   | +0.45%      |
+----------------------------------------+-------------------+--------------------+-----------+-----------------+------------+-------------+

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                         | time (kde mode)                                     | memory                                     |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                 | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000Events () | 3.368ms (±0.00%)   | 4.834ms (±0.00%)   | -30.34%   | 38.517mb        | 38.337mb   | +0.47%      |
| benchSave10000Events () | 578.581ms (±0.00%) | 385.450ms (±0.00%) | +50.11%   | 38.661mb        | 38.409mb   | +0.65%      |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBench
=======================

+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                               | memory                                     |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>  | Tag: base       | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 3.316s (±0.00%) | 3.270s (±0.00%) | +1.41%    | 48.166mb        | 47.434mb   | +1.54%      |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBatchBench
============================

+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                                   | memory                                     |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>    | Tag: base         | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 89.917ms (±0.00%) | 84.448ms (±0.00%) | +6.48%    | 35.677mb        | 35.503mb   | +0.49%      |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+

SimpleSetupStreamStoreBench
===========================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 1.054ms (±0.00%)   | 1.015ms (±0.00%)   | +3.82%    | 35.092mb        | 35.092mb   | 0.00%       |
| benchLoad10000Events ()                | 68.580ms (±0.00%)  | 68.496ms (±0.00%)  | +0.12%    | 35.092mb        | 35.092mb   | 0.00%       |
| benchSave1Event ()                     | 1.033ms (±0.00%)   | 987.500μs (±0.00%) | +4.60%    | 35.092mb        | 35.092mb   | 0.00%       |
| benchSave10000Events ()                | 344.705ms (±0.00%) | 334.669ms (±0.00%) | +3.00%    | 35.092mb        | 35.092mb   | 0.00%       |
| benchSave10000Aggregates ()            | 7.818s (±0.00%)    | 7.879s (±0.00%)    | -0.77%    | 35.092mb        | 35.092mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 5.130s (±0.00%)    | 5.120s (±0.00%)    | +0.20%    | 35.092mb        | 35.092mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SimpleSetupBench
================

+----------------------------------------+--------------------+-----------+------------+-------------+
|                                        | time (kde mode)                | memory                   |
+----------------------------------------+--------------------+-----------+------------+-------------+
| subject                                | Tag: base          | time-diff | Tag: base  | memory-diff |
+----------------------------------------+--------------------+-----------+------------+-------------+
| benchLoad1Event ()                     | 1.006ms (±0.00%)   | +0.00%    | 35.467mb   | +0.00%      |
| benchLoad10000Events ()                | 65.490ms (±0.00%)  | +0.00%    | 35.467mb   | +0.00%      |
| benchSave1Event ()                     | 1.035ms (±0.00%)   | +0.00%    | 34.934mb   | +0.00%      |
| benchSave10000Events ()                | 239.832ms (±0.00%) | +0.00%    | 34.934mb   | +0.00%      |
| benchSave10000Aggregates ()            | 7.461s (±0.00%)    | +0.00%    | 34.934mb   | +0.00%      |
| benchSave10000AggregatesTransaction () | 4.843s (±0.00%)    | +0.00%    | 34.934mb   | +0.00%      |
+----------------------------------------+--------------------+-----------+------------+-------------+

This comment gets update everytime a new commit comes in!

@DanielBadura

Copy link
Copy Markdown
Member

A note in the upgrade path is missing. Also, would be nice to update the min MSI for infection so that the job is green again.

@DanielBadura DanielBadura changed the title remove legacy doctrine store Remove deprecated DoctrineDbalStore in favor of StreamDoctrineDbalStore Jul 18, 2025
@DavidBadura
DavidBadura force-pushed the remove-legacy-store branch from dba0165 to ee4fafb Compare July 23, 2025 12:31
@DavidBadura
DavidBadura merged commit fa2c744 into 4.0.x Jul 23, 2025
39 of 40 checks passed
@DavidBadura
DavidBadura deleted the remove-legacy-store branch July 23, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants