add identifier component#771
Merged
Merged
Conversation
DavidBadura
force-pushed
the
identifier
branch
from
September 2, 2025 15:42
18c4824 to
16c0172
Compare
Member
Author
|
@DanielBadura Should we keep |
DavidBadura
force-pushed
the
identifier
branch
from
September 2, 2025 15:50
16c0172 to
e6a72c8
Compare
|
Hello 👋 here is the most recent benchmark result:
This comment gets update everytime a new commit comes in! |
DavidBadura
force-pushed
the
identifier
branch
from
September 2, 2025 15:59
917b4c3 to
b1441e3
Compare
DavidBadura
force-pushed
the
identifier
branch
from
September 2, 2025 16:01
b1441e3 to
7b70aa1
Compare
DavidBadura
force-pushed
the
identifier
branch
from
September 2, 2025 16:49
fef4d56 to
8162b6a
Compare
Member
|
I'm not sure. This would make the BC-Break minimal for the users, but do we gain something else from it? Right now, we don't have anything where we would want to differntiate between an |
Member
Author
|
Exactly, for BC, and to be more specific, an |
DanielBadura
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We will have different types of identifiers in the future, not just "aggregate root id." Therefore, it makes sense to create a general interface for them.
In addition, the return type of
fromStringhas changed fromselftostatic.