Inmemory store 1 based index#790
Merged
DavidBadura merged 2 commits intoNov 21, 2025
Merged
Conversation
DanielBadura
approved these changes
Nov 21, 2025
DanielBadura
left a comment
DanielBadura
left a comment
Member
There was a problem hiding this comment.
@DavidBadura we already discussed changing it to non-zero based array, so LGTM
Member
|
@ergosarapu thank you! |
Contributor
Author
|
@DavidBadura Unfortunately this fix didn't carry over to latest release 3.14.0 |
Member
|
Sorry 🙈 we released the fix with version 3.14.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for issue patchlevel/event-sourcing-bundle#274
It changes the internal messages indexing from 0-based to 1-based indexing.