Skip to content

Inmemory store 1 based index #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DavidBadura merged 2 commits into from
Nov 21, 2025
Merged

Inmemory store 1 based index #790

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4571afd
Reindex messages to 1-based
ergosarapu Nov 21, 2025
9daa973
Merge branch '3.13.x' into inmemory-store-1-based-index
ergosarapu Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Store/InMemoryStore.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@

final class InMemoryStore implements StreamStore
{
/** @var array<0|positive-int, Message> */
/** @var array<positive-int, Message> */
private array $messages = [];

/** @param list<Message> $messages */
Expand Down Expand Up @@ -104,7 +104,7 @@ public function save(Message ...$messages): void
$message = $message->withHeader(new RecordedOnHeader($this->clock->now()));
}

$this->messages[] = $message;
$this->messages[$count] = $message;
}
});
}
Expand Down Expand Up @@ -169,7 +169,7 @@ public function archive(Criteria|null $criteria = null): void
}
}

/** @return array<positive-int|0, Message> */
/** @return array<positive-int, Message> */
private function filter(Criteria|null $criteria): array
{
if (!$criteria) {
Expand Down
Loading