Add MissingHeaders if no header found#867
Merged
Merged
Conversation
|
Hello 👋 here is the most recent benchmark result:
This comment gets update everytime a new commit comes in! |
DanielBadura
force-pushed
the
dont-crash-if-header-missing
branch
from
June 22, 2026 09:35
f4fc2a2 to
05a0da1
Compare
MissingHeader if no header foundMissingHeaders if no header found
DavidBadura
requested changes
Jun 22, 2026
DavidBadura
left a comment
Member
There was a problem hiding this comment.
That should be optional. There are headers that are business-critical (e.g., the tenant header). if one of those isn't serialized for some reason, I think it should crash.
It would be best to be able to specify which headers are allowed to be "missing", so if a header is no longer present, you simply list it. Or you could specify * to allow all of them. Like MissingApply.
That way, it wouldn't be a breaking change.
DavidBadura
approved these changes
Jun 29, 2026
DanielBadura
force-pushed
the
dont-crash-if-header-missing
branch
2 times, most recently
from
June 30, 2026 06:53
d00c62a to
c5f436d
Compare
…the Registry cannot find the headers. It is a collection of missing Headers Make the missing header configurable Add * wildcard
DanielBadura
force-pushed
the
dont-crash-if-header-missing
branch
from
June 30, 2026 07:27
c5f436d to
4cc34a6
Compare
DavidBadura
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is kinda BC-Break, as the behaviour is changing greatly.Not sure if this is the right path, as the app could still try to load the original Header from the Message - and then it would still crash, but there we also have
hasHeaderso it is possible to handle it.closes #818