Skip to content

Check the result of GET_LOCK if lock could be acquired#869

Merged
DanielBadura merged 2 commits into
3.19.xfrom
fix-acquiring-lock
Jun 23, 2026
Merged

Check the result of GET_LOCK if lock could be acquired#869
DanielBadura merged 2 commits into
3.19.xfrom
fix-acquiring-lock

Conversation

@DanielBadura

@DanielBadura DanielBadura commented Jun 23, 2026

Copy link
Copy Markdown
Member

No description provided.

@DanielBadura
DanielBadura requested a review from DavidBadura June 23, 2026 10:34
@DanielBadura DanielBadura self-assigned this Jun 23, 2026
@DanielBadura DanielBadura added the bug Something isn't working label Jun 23, 2026
@DanielBadura DanielBadura added this to the 3.19.2 milestone Jun 23, 2026
@github-actions

github-actions Bot commented Jun 23, 2026 •
edited
Loading

Copy link
Copy Markdown

Hello 👋

here is the most recent benchmark result: 

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                         | time (kde mode)                                     | memory                                     |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                 | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000Events () | 4.983ms (±0.00%)   | 5.680ms (±0.00%)   | -12.27%   | 35.650mb        | 36.167mb   | -1.43%      |
| benchSave10000Events () | 333.382ms (±0.00%) | 341.793ms (±0.00%) | -2.46%    | 35.651mb        | 35.651mb   | 0.00%       |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SimpleSetupStreamStoreBench
===========================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 1.087ms (±0.00%)   | 1.094ms (±0.00%)   | -0.64%    | 35.206mb        | 35.206mb   | 0.00%       |
| benchLoad10000Events ()                | 69.056ms (±0.00%)  | 68.563ms (±0.00%)  | +0.72%    | 35.206mb        | 35.206mb   | 0.00%       |
| benchSave1Event ()                     | 1.237ms (±0.00%)   | 1.211ms (±0.00%)   | +2.19%    | 35.206mb        | 35.206mb   | 0.00%       |
| benchSave10000Events ()                | 278.571ms (±0.00%) | 281.888ms (±0.00%) | -1.18%    | 35.206mb        | 35.206mb   | 0.00%       |
| benchSave10000Aggregates ()            | 8.666s (±0.00%)    | 8.761s (±0.00%)    | -1.08%    | 35.206mb        | 35.206mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 5.641s (±0.00%)    | 5.619s (±0.00%)    | +0.40%    | 35.206mb        | 35.206mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SimpleSetupBench
================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 1.056ms (±0.00%)   | 1.090ms (±0.00%)   | -3.12%    | 35.044mb        | 35.044mb   | 0.00%       |
| benchLoad10000Events ()                | 60.394ms (±0.00%)  | 65.368ms (±0.00%)  | -7.61%    | 35.044mb        | 35.044mb   | 0.00%       |
| benchSave1Event ()                     | 1.231ms (±0.00%)   | 1.304ms (±0.00%)   | -5.57%    | 35.044mb        | 35.044mb   | 0.00%       |
| benchSave10000Events ()                | 211.062ms (±0.00%) | 218.934ms (±0.00%) | -3.60%    | 35.044mb        | 35.044mb   | 0.00%       |
| benchSave10000Aggregates ()            | 8.230s (±0.00%)    | 8.432s (±0.00%)    | -2.40%    | 35.044mb        | 35.044mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 5.370s (±0.00%)    | 5.513s (±0.00%)    | -2.59%    | 35.045mb        | 35.045mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBatchBench
============================

+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                                   | memory                                     |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>    | Tag: base         | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 80.310ms (±0.00%) | 82.050ms (±0.00%) | -2.12%    | 35.544mb        | 35.544mb   | 0.00%       |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBench
=======================

+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                               | memory                                     |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>  | Tag: base       | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 3.327s (±0.00%) | 3.414s (±0.00%) | -2.55%    | 47.558mb        | 47.558mb   | 0.00%       |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+

CommandToQueryBench
===================

+----------------+------------------+------------------+-----------+-----------------+------------+-------------+
|                | time (kde mode)                                 | memory                                     |
+----------------+------------------+------------------+-----------+-----------------+------------+-------------+
| subject        | Tag: <current>   | Tag: base        | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------+------------------+------------------+-----------+-----------------+------------+-------------+
| benchCreate () | 2.843ms (±0.00%) | 2.852ms (±0.00%) | -0.31%    | 4.896mb         | 4.896mb    | -0.02%      |
| benchUpdate () | 4.260ms (±0.00%) | 4.343ms (±0.00%) | -1.92%    | 5.031mb         | 5.031mb    | 0.00%       |
| benchBoth ()   | 6.516ms (±0.00%) | 6.421ms (±0.00%) | +1.47%    | 4.921mb         | 4.921mb    | 0.00%       |
+----------------+------------------+------------------+-----------+-----------------+------------+-------------+

PersonalDataBench
=================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 1.042ms (±0.00%)   | 1.033ms (±0.00%)   | +0.89%    | 35.585mb        | 35.585mb   | 0.00%       |
| benchLoad10000Events ()                | 96.779ms (±0.00%)  | 98.172ms (±0.00%)  | -1.42%    | 35.585mb        | 35.585mb   | 0.00%       |
| benchSave1Event ()                     | 1.838ms (±0.00%)   | 1.881ms (±0.00%)   | -2.24%    | 35.585mb        | 35.585mb   | 0.00%       |
| benchSave10000Events ()                | 237.559ms (±0.00%) | 244.958ms (±0.00%) | -3.02%    | 35.586mb        | 35.586mb   | 0.00%       |
| benchSave10000Aggregates ()            | 12.841s (±0.00%)   | 12.996s (±0.00%)   | -1.20%    | 35.585mb        | 35.585mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 9.972s (±0.00%)    | 10.105s (±0.00%)   | -1.32%    | 36.044mb        | 36.044mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SnapshotsBench
==============

+----------------------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                   | memory                                     |
+----------------------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>    | Tag: base         | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| benchLoad10000EventsMissingSnapshot () | 59.240ms (±0.00%) | 64.077ms (±0.00%) | -7.55%    | 35.049mb        | 35.049mb   | 0.00%       |
| benchLoad10000Events ()                | 1.318ms (±0.00%)  | 1.316ms (±0.00%)  | +0.09%    | 35.049mb        | 35.049mb   | 0.00%       |
+----------------------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+

This comment gets update everytime a new commit comes in!

@DanielBadura
DanielBadura force-pushed the fix-acquiring-lock branch 5 times, most recently from 69f1959 to cf1cb59 Compare June 23, 2026 11:59
@DanielBadura
DanielBadura requested a review from DavidBadura June 23, 2026 15:52
@DanielBadura
DanielBadura merged commit 273ad58 into 3.19.x Jun 23, 2026
40 of 41 checks passed
@DanielBadura
DanielBadura deleted the fix-acquiring-lock branch June 23, 2026 20:23
@github-actions github-actions Bot mentioned this pull request Jun 23, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DavidBadura DavidBadura DavidBadura approved these changes

Assignees

@DanielBadura DanielBadura

Labels

bug Something isn't working

Projects

None yet

Milestone

3.19.2

Development

Successfully merging this pull request may close these issues.

2 participants

@DanielBadura @DavidBadura