simplify extension api

Author: DavidBadura

src/CoreExtension.php

@@ -9,7 +9,7 @@
 use Patchlevel\Hydrator\Middleware\Middleware;
 use Patchlevel\Hydrator\Middleware\TransformMiddleware;
 
-final class CoreExtension implements MiddlewareProvider, GuesserProvider
+final class CoreExtension extends Extension
 {
     /** @return iterable<Middleware|array{0: Middleware, 1?: int}> */
     public function middlewares(): iterable

src/Cryptography/CryptographyExtension.php

@@ -4,12 +4,11 @@
 
 namespace Patchlevel\Hydrator\Cryptography;
 
+use Patchlevel\Hydrator\Extension;
 use Patchlevel\Hydrator\Metadata\MetadataEnricher;
-use Patchlevel\Hydrator\MetadataEnricherProvider;
 use Patchlevel\Hydrator\Middleware\Middleware;
-use Patchlevel\Hydrator\MiddlewareProvider;
 
-final class CryptographyExtension implements MiddlewareProvider, MetadataEnricherProvider
+final class CryptographyExtension extends Extension
 {
     public function __construct(
         private readonly PayloadCryptographer $cryptography,

src/Extension.php

@@ -0,0 +1,30 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Patchlevel\Hydrator;
+
+use Patchlevel\Hydrator\Guesser\Guesser;
+use Patchlevel\Hydrator\Metadata\MetadataEnricher;
+use Patchlevel\Hydrator\Middleware\Middleware;
+
+abstract class Extension
+{
+    /** @return iterable<Middleware|array{0: Middleware, 1?: int}> */
+    public function middlewares(): iterable
+    {
+        return [];
+    }
+
+    /** @return iterable<MetadataEnricher|array{0: MetadataEnricher, 1?: int}> */
+    public function metadataEnrichers(): iterable
+    {
+        return [];
+    }
+
+    /** @return iterable<Guesser|array{0: Guesser, 1?: int}> */
+    public function guesser(): iterable
+    {
+        return [];
+    }
+}

src/GuesserProvider.php

@@ -122,7 +122,7 @@ private function metadata(string $class): ClassMetadata
         return $metadata;
     }
 
-    /** @param iterable<MiddlewareProvider|MetadataEnricherProvider|GuesserProvider> $extensions */
+    /** @param iterable<Extension> $extensions */
     public static function create(
         iterable $extensions = [],
         bool $defaultLazy = false,
@@ -134,30 +134,22 @@ public static function create(
         $guessers = [];
 
         foreach ($extensions as $extension) {
-            if ($extension instanceof MiddlewareProvider) {
-                foreach ($extension->middlewares() as $entry) {
-                    if ($entry instanceof Middleware) {
-                        $middlewares[0][] = $entry;
-                    } else {
-                        $middlewares[$entry[1] ?? 0][] = $entry[0];
-                    }
+            foreach ($extension->middlewares() as $entry) {
+                if ($entry instanceof Middleware) {
+                    $middlewares[0][] = $entry;
+                } else {
+                    $middlewares[$entry[1] ?? 0][] = $entry[0];
                 }
             }
 
-            if ($extension instanceof MetadataEnricherProvider) {
-                foreach ($extension->metadataEnrichers() as $entry) {
-                    if ($entry instanceof MetadataEnricher) {
-                        $enrichers[0][] = $entry;
-                    } else {
-                        $enrichers[$entry[1] ?? 0][] = $entry[0];
-                    }
+            foreach ($extension->metadataEnrichers() as $entry) {
+                if ($entry instanceof MetadataEnricher) {
+                    $enrichers[0][] = $entry;
+                } else {
+                    $enrichers[$entry[1] ?? 0][] = $entry[0];
                 }
             }
 
-            if (!($extension instanceof GuesserProvider)) {
-                continue;
-            }
-
             foreach ($extension->guesser() as $entry) {
                 if ($entry instanceof Guesser) {
                     $guessers[0][] = $entry;

src/MetadataEnricherProvider.php

@@ -4,14 +4,12 @@
 
 namespace Patchlevel\Hydrator\Tests\Unit\Fixture;
 
+use Patchlevel\Hydrator\Extension;
 use Patchlevel\Hydrator\Guesser\Guesser;
-use Patchlevel\Hydrator\GuesserProvider;
 use Patchlevel\Hydrator\Metadata\MetadataEnricher;
-use Patchlevel\Hydrator\MetadataEnricherProvider;
 use Patchlevel\Hydrator\Middleware\Middleware;
-use Patchlevel\Hydrator\MiddlewareProvider;
 
-final class Extension implements MiddlewareProvider, MetadataEnricherProvider, GuesserProvider
+final class DummyExtension extends Extension
 {
     /**
      * @param iterable<Middleware>       $middlewares

src/MetadataHydrator.php

@@ -25,8 +25,8 @@
 use Patchlevel\Hydrator\Tests\Unit\Fixture\Circle2Dto;
 use Patchlevel\Hydrator\Tests\Unit\Fixture\Circle3Dto;
 use Patchlevel\Hydrator\Tests\Unit\Fixture\DefaultDto;
+use Patchlevel\Hydrator\Tests\Unit\Fixture\DummyExtension;
 use Patchlevel\Hydrator\Tests\Unit\Fixture\Email;
-use Patchlevel\Hydrator\Tests\Unit\Fixture\Extension;
 use Patchlevel\Hydrator\Tests\Unit\Fixture\InferNormalizerDto;
 use Patchlevel\Hydrator\Tests\Unit\Fixture\InferNormalizerWithIterablesDto;
 use Patchlevel\Hydrator\Tests\Unit\Fixture\InferNormalizerWithNullableDto;
@@ -168,7 +168,7 @@ public function testExtractWithContext(): void
                 $this->isInstanceOf(Stack::class),
             )->willReturn($expect);
 
-        $hydrator = MetadataHydrator::create([new Extension([$middleware])]);
+        $hydrator = MetadataHydrator::create([new DummyExtension([$middleware])]);
 
         $data = $hydrator->extract($object, ['context' => '123']);
 
@@ -286,7 +286,7 @@ public function testHydrateWithContext(): void
                 $this->isInstanceOf(Stack::class),
             )->willReturn($expect);
 
-        $hydrator = MetadataHydrator::create([new Extension([$middleware])]);
+        $hydrator = MetadataHydrator::create([new DummyExtension([$middleware])]);
 
         $object = $hydrator->hydrate(InferNormalizerDto::class, $data, ['context' => '123']);
 
@@ -556,7 +556,7 @@ public function guess(ObjectType $type): Normalizer|null
 
         $hydrator = MetadataHydrator::create(
             [
-                new Extension(
+                new DummyExtension(
                     [
                         new class implements Middleware {
                         /**