refactor: extract duplicated formatCliOutput to util.ts

formatPatchloomOutput (quickActions.ts) and formatBatchOutput
(batchApply.ts) were identical. Extract to shared formatCliOutput
in util.ts and delegate from both call sites.

Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>

Author: SebTardif

src/commands/batchApply.ts

@@ -1,6 +1,7 @@
 import { execFile } from "node:child_process";
 import type * as VSCode from "vscode";
 import { patchloomNeedsUpgrade, resolvePatchloomStatus } from "../binary/patchloom.js";
+import { formatCliOutput } from "../util.js";
 import { getPatchloomLog } from "../logging/outputChannel.js";
 import { activeWorkspaceFolder } from "../workspace/readiness.js";
 
@@ -135,10 +136,5 @@ function executePatchloomWithStdin(
 }
 
 function formatBatchOutput(result: BatchCommandResult): string {
-  const output = `${result.stderr}\n${result.stdout}`
-    .split(/\r?\n/)
-    .map((line) => line.trim())
-    .filter((line) => line.length > 0)
-    .join(" ");
-  return output || `exit code ${result.exitCode}`;
+  return formatCliOutput(result);
 }

src/commands/quickActions.ts

@@ -6,7 +6,7 @@ import { promisify } from "node:util";
 import type * as VSCode from "vscode";
 import { patchloomNeedsUpgrade, resolvePatchloomStatus } from "../binary/patchloom.js";
 import { getPatchloomLog } from "../logging/outputChannel.js";
-import { formatError } from "../util.js";
+import { formatCliOutput, formatError } from "../util.js";
 import { activeWorkspaceFolder, describeWorkspaceEnvironment } from "../workspace/readiness.js";
 
 const execFileAsync = promisify(execFile);
@@ -641,12 +641,7 @@ async function executePatchloom(
 }
 
 function formatPatchloomOutput(result: PatchloomCommandResult): string {
-  const output = `${result.stderr}\n${result.stdout}`
-    .split(/\r?\n/)
-    .map((line) => line.trim())
-    .filter((line) => line.length > 0)
-    .join(" ");
-  return output || `exit code ${result.exitCode}`;
+  return formatCliOutput(result);
 }
 
 function sameFilePath(left: string, right: string): boolean {

src/util.ts

@@ -3,4 +3,13 @@ export function formatError(error: unknown): string {
     return error.message;
   }
   return String(error);
+}
+
+export function formatCliOutput(result: { exitCode: number; stdout: string; stderr: string }): string {
+  const output = `${result.stderr}\n${result.stdout}`
+    .split(/\r?\n/)
+    .map((line) => line.trim())
+    .filter((line) => line.length > 0)
+    .join(" ");
+  return output || `exit code ${result.exitCode}`;
 }