fix: patch test VS Code after download to suppress macOS windows

The hide-test-vscode.sh script was running before VS Code was downloaded,
so the LSUIElement patch had no .app bundles to apply to. Now:

- runExtensionTests.ts calls downloadAndUnzipVSCode() first, then patches
- CI splits UI tests into setup -> patch -> run
- hide script also covers ExTester's test-resources/ directory
- Removed redundant pre-patch calls from npm scripts

Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>

Author: SebTardif

.github/workflows/ci.yml

@@ -60,11 +60,14 @@ jobs:
       - name: Install dependencies
         run: npm ci
 
-      - name: Patch test VS Code to run as background app
-        run: bash scripts/hide-test-vscode.sh
-
       - name: Run VS Code extension tests
         run: npm run test:all
 
+      - name: Setup UI test VS Code
+        run: npx extest setup-tests --code_version max --extensions_dir .vscode-test/extensions
+
+      - name: Patch test VS Code to run as background app
+        run: bash scripts/hide-test-vscode.sh
+
       - name: Run UI tests
-        run: npm run test:ui
+        run: npx extest run-tests './out-uitest/test/ui/*.test.js' --extensions_dir .vscode-test/extensions

package.json

@@ -110,10 +110,10 @@
     "compile-uitests": "tsc -p ./tsconfig.uitest.json",
     "watch": "tsc -watch -p ./",
     "test:unit": "node --test ./out-test/test/unit/*.test.js",
-    "test:extension": "bash scripts/hide-test-vscode.sh && node ./out-test/test/suite/runExtensionTests.js",
+    "test:extension": "node ./out-test/test/suite/runExtensionTests.js",
     "test:ui": "npm run compile && npm run compile-uitests && extest setup-and-run './out-uitest/test/ui/*.test.js' --code_version max --extensions_dir .vscode-test/extensions",
     "test": "npm run compile && npm run compile-tests && npm run test:unit",
-    "test:all": "npm run compile && npm run compile-tests && bash scripts/hide-test-vscode.sh && npm run test:unit && npm run test:extension",
+    "test:all": "npm run compile && npm run compile-tests && npm run test:unit && npm run test:extension",
     "vscode:prepublish": "npm run compile",
     "package": "vsce package",
     "check": "npm run test && npm run package"

scripts/hide-test-vscode.sh

@@ -3,6 +3,10 @@
 # background apps (no Dock icon, no Cmd+Tab, no focus stealing).
 # Safe to run multiple times; skips already-patched bundles.
 # No-op on Linux/Windows.
+#
+# Covers:
+#   .vscode-test/       — @vscode/test-electron downloads
+#   $TMPDIR/test-resources/ — vscode-extension-tester (ExTester) downloads
 
 set -euo pipefail
 
@@ -13,8 +17,12 @@ fi
 patched=0
 shopt -s nullglob
 
+# ExTester uses $TEST_RESOURCES or $TMPDIR/test-resources
+extest_dir="${TEST_RESOURCES:-${TMPDIR:-/tmp}/test-resources}"
+
 for plist in \
-  .vscode-test/*/Visual\ Studio\ Code*.app/Contents/Info.plist; do
+  .vscode-test/*/Visual\ Studio\ Code*.app/Contents/Info.plist \
+  "$extest_dir"/*/Visual\ Studio\ Code*.app/Contents/Info.plist; do
   [ -f "$plist" ] || continue
 
   if plutil -extract LSUIElement raw "$plist" >/dev/null 2>&1; then

test/suite/runExtensionTests.ts

@@ -1,11 +1,22 @@
 import * as path from "node:path";
-import { runTests } from "@vscode/test-electron";
+import { execSync } from "node:child_process";
+import { downloadAndUnzipVSCode, runTests } from "@vscode/test-electron";
 
 async function main(): Promise<void> {
   const extensionDevelopmentPath = path.resolve(__dirname, "../../..");
   const extensionTestsPath = path.resolve(__dirname, "./index.js");
 
+  // Download VS Code FIRST so the .app bundle exists on disk
+  const vscodeExecutablePath = await downloadAndUnzipVSCode();
+
+  // Patch the downloaded bundle to suppress Dock icon / window focus on macOS
+  execSync("bash scripts/hide-test-vscode.sh", {
+    cwd: extensionDevelopmentPath,
+    stdio: "inherit",
+  });
+
   await runTests({
+    vscodeExecutablePath,
     extensionDevelopmentPath,
     extensionTestsPath,
     launchArgs: [