Skip to content

Commit a3873f2

Browse files
committed
test: add line count assertions to logResult tests
Strengthens 3 logResult tests that only checked individual line content but not total line count, while logCommand and simpler logResult tests already asserted lines.length. Now all logResult tests verify both content and count, catching regressions that add extra output lines. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
1 parent a598559 commit a3873f2

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

test/unit/outputChannel.test.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ test("logResult appends stdout, stderr, and exit code", () => {
4747

4848
log.logResult(0, "output line 1\noutput line 2\n", "warning\n");
4949

50+
assert.equal(lines.length, 4, "should produce 2 stdout + 1 stderr + 1 exit code line");
5051
assert.ok(lines.some(l => l === "output line 1"));
5152
assert.ok(lines.some(l => l === "output line 2"));
5253
assert.ok(lines.some(l => l.includes("stderr: warning")));
@@ -147,6 +148,7 @@ test("logResult splits Windows-style CRLF line endings", () => {
147148

148149
log.logResult(0, "line1\r\nline2\r\n", "");
149150

151+
assert.equal(lines.length, 3, "should produce 2 stdout + 1 exit code line");
150152
assert.ok(lines.some(l => l === "line1"));
151153
assert.ok(lines.some(l => l === "line2"));
152154
assert.ok(lines.some(l => l.includes("Exit code: 0")));
@@ -162,6 +164,7 @@ test("logResult handles multiline stderr", () => {
162164

163165
log.logResult(1, "", "error line 1\nerror line 2");
164166

167+
assert.equal(lines.length, 3, "should produce 2 stderr + 1 exit code line");
165168
assert.ok(lines.some(l => l === "stderr: error line 1"));
166169
assert.ok(lines.some(l => l === "stderr: error line 2"));
167170
assert.ok(lines.some(l => l.includes("Exit code: 1")));

0 commit comments

Comments
 (0)