Skip to content

Commit b0dcde9

Browse files
authored
docs: clarify that auto-approve self-mod bypass is no longer needed after #160 (#161)
The specific emergency procedure (bypass + --admin) for PRs that touch auto-approve.yml is no longer required. The landed fix ensures the review is submitted early and the workflow run succeeds. Updated wording in AGENTS.md (and cross-referenced skills) to reflect the resolution of #159. The general emergency hatch for other auto-approve breakage remains documented in ci-branch-protection. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
1 parent 74ea588 commit b0dcde9

1 file changed

Lines changed: 8 additions & 8 deletions

File tree

AGENTS.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -134,14 +134,14 @@ All I/O-dependent functions accept an `inputs` object with injectable callbacks
134134
backed by an open (draft) PR from the start. See `~/.grok/skills/owned-repo-gate/SKILL.md`.
135135

136136
- **Auto-approve self-modification:** PRs that change `.github/workflows/auto-approve.yml`
137-
cause GitHub to emit only "push" validation runs (0 jobs, failure) using the PR's workflow content
138-
(the pull_request runs use the definition from main). The approve step runs early using
139-
GITHUB_TOKEN (before wf-changes detection or merge logic) so reviews are added when the
140-
pull_request workflow runs from main. The Enable auto-merge step uses `|| echo` so the
141-
workflow reports success even when merge enable falls back or is restricted. In rare cases
142-
where no review appears, use the emergency bypass in ci-branch-protection skill + #159
143-
(add bypass actor, `gh pr merge --admin`, remove bypass immediately). See also patchloom's
144-
auto-approve.yml for the reference pattern.
137+
still cause GitHub to emit "push" validation runs (0 jobs, failure) using the PR's workflow content
138+
(pull_request runs always use the definition from main). However, the approve step now runs
139+
early using GITHUB_TOKEN, and the Enable auto-merge step uses `|| echo` (plus a hardened
140+
wf-changes check), so the review is submitted and the workflow run reports success.
141+
The specific "stuck in REVIEW_REQUIRED with no bot review" case that required the bypass
142+
for auto-approve self-mods (see historical #157 / #159) is resolved. The general emergency
143+
hatch in ci-branch-protection remains available for other auto-approve outages. See
144+
patchloom's auto-approve.yml for the reference pattern.
145145

146146
## Release PRs - Strong Guard
147147

0 commit comments

Comments
 (0)