ci: run integration tests on all three OSes#81
Merged
Conversation
Expand integration-test to a matrix of ubuntu-latest, macos-latest, and windows-latest. Use xvfb-run on Linux for headless display. Restrict harden-runner to Linux only (it only supports Ubuntu VMs). Closes #79 Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expand the
integration-testjob from macOS-only to a matrix of Ubuntu, macOS, and Windows.Changes:
strategy.matrix.oswith all three GitHub-hosted runnersxvfb-runon Linux for headless displayharden-runnerto Linux only (it only supports Ubuntu VMs and prints a confusing warning on macOS/Windows)hide-test-vscode.sh(it already no-ops on non-Darwin)Why: VS Code extensions interact with OS-level features (binary discovery, PATH, file system). Integration tests should cover all platforms, just like the unit tests already do.
All runners are free for this public repo. No billing impact.
Note: After CI runs and the new matrix check names exist, the branch protection ruleset needs to be updated to require
integration-test (ubuntu-latest),integration-test (macos-latest), andintegration-test (windows-latest)instead of the old singleintegration-test.Closes #79