Skip to content

Fix trader crashes on object-form mods, make Find best return URL only #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pathanin merged 2 commits into from
Jul 25, 2026
Merged

Fix trader crashes on object-form mods, make Find best return URL only #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47d8d77
Handle object-form mods from the trade API
Jul 25, 2026
bd28bd9
Make "Find best" return the trade URL without listing items
Jul 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 14 additions & 56 deletions src/Classes/TradeQuery.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1022,70 +1022,28 @@ function TradeQueryClass:PriceItemRowDisplay(row_idx, top_pane_alignment_ref, ro
controls["uri"..context.row_idx]:SetText(url, true)
return
end
-- Register the search so we get a short shareable link, but stop there: the item
-- listings are never fetched. Press "Price Item" on the resulting URL to pull them.
context.controls["priceButton"..context.row_idx].label = "Searching..."
self.lastQueries[row_idx] = query
self.tradeQueryRequests:SearchWithQueryWeightAdjusted(self.pbRealm, self.pbLeague, query,
function(items, errMsg)
if errMsg then
self:SetNotice(context.controls.pbNotice, colorCodes.NEGATIVE .. errMsg)
context.controls["priceButton"..context.row_idx].label = "Price Item"
return
else
self:SetNotice(context.controls.pbNotice, "")
end

local selectedSlot = getSelectedSlot()
local itemsSafe = self:FilterToSafeItems(items, selectedSlot and selectedSlot.slotName)

if self.tradeQueryGenerator.lastAugmentBehaviour == "Copy Current" or self.tradeQueryGenerator.lastAnointBehaviour == "Copy Current" then
for i, _ in ipairs(itemsSafe) do
local item = new("Item", itemsSafe[i].item_string)
-- avoid interacting with badly parsed stuff
if item.base and item.type then
self.itemsTab:CopyAnointsAndAugments(item, true, true, context.slotTbl.slotName)
itemsSafe[i].item_string = item:BuildRaw()
end
end
elseif self.tradeQueryGenerator.lastAugmentBehaviour == "Remove" then
for item_idx, _ in ipairs(itemsSafe) do
local item = new("Item", itemsSafe[item_idx].item_string)
-- sockets are kept as-is so the user can see e.g. exceptional or corrupted sockets
local validRunes = self.itemsTab:GetValidRunesForItem(item)
for rune_idx, _ in ipairs(item.runes or {}) do
if not self.itemsTab:IsSocketBoundRune(item, item.runes[rune_idx], validRunes) then
item.runes[rune_idx] = "None"
end
end
item:UpdateRunes()
itemsSafe[item_idx].item_string = item:BuildRaw()
end
elseif self.tradeQueryGenerator.lastAnointBehaviour == "Remove" then
for i, _ in ipairs(itemsSafe) do
local item = new("Item", itemsSafe[i].item_string)
item.enchantModLines = {}
itemsSafe[i].item_string = item:BuildRaw()
end
end

self.resultTbl[context.row_idx] = itemsSafe
self:UpdateControlsWithItems(context.row_idx)
context.controls["priceButton"..context.row_idx].label = "Price Item"
end,
{
callbackQueryId = function(queryId)
local url = self.tradeQueryRequests:buildUrl(self.hostName .. "trade2/search", self.pbRealm, self.pbLeague, queryId)
controls["uri"..context.row_idx]:SetText(url, true)
end
}
)
self.tradeQueryRequests:PerformSearch(self.pbRealm, self.pbLeague, query, function(response, errMsg)
context.controls["priceButton"..context.row_idx].label = "Price Item"
-- Set the URL even on error, so an empty search still gives a link to loosen in the browser
if response and response.id then
local url = self.tradeQueryRequests:buildUrl(self.hostName .. "trade2/search", self.pbRealm, self.pbLeague, response.id)
controls["uri"..context.row_idx]:SetText(url, true)
end
self:SetNotice(context.controls.pbNotice, errMsg and (colorCodes.NEGATIVE .. errMsg) or "")
end)
end)
end)
controls["bestButton"..row_idx].shown = function() return not self.resultTbl[row_idx] end
controls["bestButton"..row_idx].enabled = function() return self.pbLeague end
controls["bestButton"..row_idx].tooltipText = [[Creates a weighted search to find the highest Stat Value items for this slot.
Note that even if you are authenticated, you can click this button again to show the search link.
The trade link is put in the box to the right; the items themselves are not fetched.
Control + click the link to open the search in your web-browser.
If you have additional requirements that the trade tool doesn't cover (e.g. Adorned Magic jewels),
you can add them, copy the link here, and press "Price Item" to evaluate the items.]]
you can add them, then press "Price Item" to evaluate the items inside Path of Building.]]
controls["bestButton" .. row_idx].onHover = function()
local button = controls["bestButton" .. row_idx]

Expand Down
23 changes: 13 additions & 10 deletions src/Classes/TradeQueryRequests.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,23 +398,23 @@ function TradeQueryRequestsClass:FetchResultBlock(url, callback)
item.explicitMods = item.explicitMods or { }

t_insert(rawLines, "Implicits: " .. (#item.enchantMods + #item.runeMods + #item.implicitMods))
for _, modLine in ipairs(item.enchantMods) do
t_insert(rawLines, "{enchant}" .. escapeGGGString(modLine))
for _, itemMod in ipairs(item.enchantMods) do
t_insert(rawLines, "{enchant}" .. escapeGGGString(itemMod.description or itemMod))
end
for _, modLine in ipairs(item.runeMods) do
t_insert(rawLines, "{enchant}{rune}" .. escapeGGGString(modLine))
for _, itemMod in ipairs(item.runeMods) do
t_insert(rawLines, "{enchant}{rune}" .. escapeGGGString(itemMod.description or itemMod))
end
for _, modLine in ipairs(item.implicitMods) do
t_insert(rawLines, escapeGGGString(modLine))
for _, itemMod in ipairs(item.implicitMods) do
t_insert(rawLines, escapeGGGString(itemMod.description or itemMod))
end
for _, modLine in ipairs(item.explicitMods) do
for _, itemMod in ipairs(item.explicitMods) do
local s = ""
for flagName, flag in pairs(modLine.flags or {}) do
for flagName, flag in pairs(itemMod.flags or {}) do
if flag then
s = s .. string.format("{%s}", flagName)
end
end
t_insert(rawLines, s .. escapeGGGString(modLine.description))
t_insert(rawLines, s .. escapeGGGString(itemMod.description or itemMod))
end
if item.mirrored then
t_insert(rawLines, "Mirrored")
Expand All @@ -428,14 +428,17 @@ function TradeQueryRequestsClass:FetchResultBlock(url, callback)
t_insert(rawLines, "Sanctified")
end

local pseudoMod = item.pseudoMods and item.pseudoMods[1]
pseudoMod = pseudoMod and (pseudoMod.description or pseudoMod)

table.insert(items, {
amount = trade_entry.listing.price.amount,
currency = trade_entry.listing.price.currency,
priceType = trade_entry.listing.price.type,
item_string = table.concat(rawLines, "\n"),
whisper = trade_entry.listing.whisper,
trader = trade_entry.listing.account.name,
weight = trade_entry.item.pseudoMods and trade_entry.item.pseudoMods[1]:match("Sum: (.+)") or "0",
weight = pseudoMod and pseudoMod:match("Sum: (.+)") or "0",
id = trade_entry.id
})
end
Expand Down
Loading