Skip to content

Stop find_c aborting on directory entries #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pathanin merged 1 commit into from
Jul 25, 2026
Merged

Stop find_c aborting on directory entries #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 22 additions & 8 deletions engine/system/win/sys_main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,10 +214,17 @@ bool find_c::FindFirst(std::filesystem::path const&& fileSpec)
auto candFilename = iter->path().filename();
if (GlobMatch(globPattern, candFilename)) {
fileName = candFilename;
isDirectory = iter->is_directory();
fileSize = iter->file_size();
auto mod = iter->last_write_time();
modified = mod.time_since_epoch().count();
// Query metadata through the error_code overloads. The throwing overloads
// abort whenever status() fails on an entry, and outside of Windows (where
// file_size() reports the cached 0 for directories) file_size() always fails
// on a directory, which would take down every search over a folder tree.
std::error_code entEc;
isDirectory = iter->is_directory(entEc);
fileSize = isDirectory ? 0 : iter->file_size(entEc);
auto mod = iter->last_write_time(entEc);
// A failed query yields file_time_type::min(), whose negative count would
// wrap to a huge timestamp and sort the entry to the top of "Last Edited".
modified = entEc ? 0 : mod.time_since_epoch().count();
return true;
}
}
Expand All @@ -234,10 +241,17 @@ bool find_c::FindNext()
auto candFilename = iter->path().filename();
if (GlobMatch(globPattern, candFilename)) {
fileName = candFilename;
isDirectory = iter->is_directory();
fileSize = iter->file_size();
auto mod = iter->last_write_time();
modified = mod.time_since_epoch().count();
// Query metadata through the error_code overloads. The throwing overloads
// abort whenever status() fails on an entry, and outside of Windows (where
// file_size() reports the cached 0 for directories) file_size() always fails
// on a directory, which would take down every search over a folder tree.
std::error_code entEc;
isDirectory = iter->is_directory(entEc);
fileSize = isDirectory ? 0 : iter->file_size(entEc);
auto mod = iter->last_write_time(entEc);
// A failed query yields file_time_type::min(), whose negative count would
// wrap to a huge timestamp and sort the entry to the top of "Last Edited".
modified = entEc ? 0 : mod.time_since_epoch().count();
return true;
}
}
Expand Down
Loading