Code cleanup: extract constants, document regex, remove dead code

- Extract search scoring constants for maintainability
- Document TypeRef regex patterns with examples
- Remove unused handleTocNavigate callback from Sidebar

Author: milanofthe

src/lib/components/api/TypeRef.svelte

@@ -21,14 +21,17 @@
 	let parts = $derived.by(() => {
 		const result: TypePart[] = [];
 
-		// Regex to match potential class names (PascalCase or known types)
-		// Split by common type syntax characters while preserving them
+		// Tokenize type string by brackets, commas, and union operators
+		// Example: "list[ClassName]" → ["list", "[", "ClassName", "]"]
+		// Example: "Optional[int | str]" → ["Optional", "[", "int", " | ", "str", "]"]
 		const tokens = type.split(/(\[|\]|,\s*|\s*\|\s*)/);
 
 		for (const token of tokens) {
 			if (!token) continue;
 
-			// Check if this token looks like a class name (PascalCase)
+			// Match PascalCase class names (no dots)
+			// Matches: "Integrator", "V1", "MyClass"
+			// Does NOT match: "list", "pathsim.Connection"
 			if (/^[A-Z][a-zA-Z0-9_]*$/.test(token)) {
 				const target = lookupRef(token);
 				if (target) {
@@ -37,7 +40,10 @@
 					result.push({ text: token, isLink: false });
 				}
 			}
-			// Check if this is a full module path like pathsim.connection.Connection
+			// Match fully qualified module paths ending with class name
+			// Format: module.submodule.ClassName
+			// Matches: "pathsim.connection.Connection", "numpy.ndarray.ndarray"
+			// Does NOT match: "Connection", "pathsim.connection"
 			else if (/^[a-z][a-z0-9_]*(\.[a-z_][a-z0-9_]*)*\.[A-Z][a-zA-Z0-9_]*$/.test(token)) {
 				// Try lookup by full path first
 				let target = lookupRef(token);

src/lib/components/layout/Sidebar.svelte

@@ -70,10 +70,6 @@
 		goto(`${base}/${result.path}`);
 	}
 
-	function handleTocNavigate(id: string) {
-		// Could track navigation for analytics or other purposes
-	}
-
 	function getTypeIcon(type: SearchResult['type']): string {
 		switch (type) {
 			case 'page': return 'file';
@@ -137,7 +133,7 @@
 
 	{#if !showResults && isApiPage && $apiModulesStore.length > 0}
 		<div class="sidebar-scrollable">
-			<ApiToc modules={$apiModulesStore} onNavigate={handleTocNavigate} />
+			<ApiToc modules={$apiModulesStore} />
 		</div>
 	{:else if !showResults && isExamplesListPage && $exampleGroupsStore.length > 0}
 		<div class="sidebar-scrollable">

src/lib/utils/search.ts

@@ -5,6 +5,21 @@
 
 import searchIndex from '$lib/api/generated/search-index.json';
 
+// Scoring weights for search relevance
+const SCORE_EXACT_MATCH = 100;
+const SCORE_PREFIX_MATCH = 50;
+const SCORE_CONTAINS = 30;
+const SCORE_MODULE_CONTAINS = 15;
+const SCORE_DESCRIPTION = 10;
+const SCORE_PARENT_CLASS = 20;
+const SCORE_TAGS = 25;
+
+// Type boost multipliers
+const BOOST_PAGE = 1.5;
+const BOOST_CLASS = 1.2;
+const BOOST_EXAMPLE = 1.15;
+const BOOST_FUNCTION = 1.1;
+
 export type SearchResultType = 'page' | 'module' | 'class' | 'function' | 'method' | 'example';
 
 export interface SearchResult {
@@ -41,39 +56,39 @@ export function search(query: string, limit: number = 20): SearchResult[] {
 			for (const term of terms) {
 				// Exact name match (highest priority)
 				if (lowerName === term) {
-					score += 100;
+					score += SCORE_EXACT_MATCH;
 				}
 				// Name starts with term
 				else if (lowerName.startsWith(term)) {
-					score += 50;
+					score += SCORE_PREFIX_MATCH;
 				}
 				// Name contains term
 				else if (lowerName.includes(term)) {
-					score += 30;
+					score += SCORE_CONTAINS;
 				}
 				// Module/category contains term
 				else if (lowerModule.includes(term)) {
-					score += 15;
+					score += SCORE_MODULE_CONTAINS;
 				}
 				// Description contains term
 				else if (lowerDesc.includes(term)) {
-					score += 10;
+					score += SCORE_DESCRIPTION;
 				}
 				// Parent class contains term
 				else if (result.parentClass?.toLowerCase().includes(term)) {
-					score += 20;
+					score += SCORE_PARENT_CLASS;
 				}
 				// Tags contain term (for examples)
 				else if (result.tags?.some(tag => tag.toLowerCase().includes(term))) {
-					score += 25;
+					score += SCORE_TAGS;
 				}
 			}
 
 			// Boost by type (pages highest, then classes, examples, functions)
-			if (result.type === 'page') score *= 1.5;
-			if (result.type === 'class') score *= 1.2;
-			if (result.type === 'example') score *= 1.15;
-			if (result.type === 'function') score *= 1.1;
+			if (result.type === 'page') score *= BOOST_PAGE;
+			if (result.type === 'class') score *= BOOST_CLASS;
+			if (result.type === 'example') score *= BOOST_EXAMPLE;
+			if (result.type === 'function') score *= BOOST_FUNCTION;
 
 			return { result, score };
 		})