✨ Preview settings#171
Conversation
Summary of ChangesHello @patou, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the user experience of the Gitmoji plugin by integrating a live preview feature directly into the settings page. Users can now instantly see how their Gitmoji-enhanced commit messages will render based on their chosen preferences, such as whether to use Unicode emojis, include descriptions, or insert at the cursor's position. This visual feedback mechanism simplifies configuration and ensures that the generated commit messages align perfectly with user expectations. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds a helpful preview feature to the settings page, allowing users to see how their gitmoji commit messages will be formatted. The implementation is mostly solid, using modern IntelliJ UI components. However, I've found a couple of issues: a significant maintainability problem with hardcoded translations for the preview text, and a minor logic bug in the preview generation itself. My review includes suggestions to address both of these points by refactoring the translation handling to use resource bundles and fixing the preview logic.
There was a problem hiding this comment.
Pull request overview
This PR adds a preview feature to the Gitmoji plugin settings page, allowing users to see how their configuration choices will affect the commit message format in real-time.
- Adds a visual preview area in the settings UI that demonstrates commit message formatting
- Implements dynamic preview updates when settings are changed
- Adds internationalization support for preview text in multiple languages
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/main/kotlin/com/github/patou/gitmoji/GitMojiConfig.kt | Adds preview panel with JTextArea, implements updatePreview() method with real-time updates, and adds getTranslatedString() for preview text localization |
| src/main/resources/messages/GitmojiBundle.properties | Adds English translations for "Settings" and "Preview" separator labels |
| src/main/resources/messages/GitmojiBundle_fr_FR.properties | Adds French translations for "Settings" and "Preview" separator labels |
| src/main/resources/messages/GitmojiBundle_zh_CN.properties | Adds Chinese translations for "Settings" and "Preview" separator labels |
| CHANGELOG.md | Documents the new preview feature in the unreleased changes section |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/qodana-action@v2025.2.3
with:
upload-result: trueContact Qodana teamContact us at qodana-support@jetbrains.com
|
Add a preview in the settings page.
