fix reporting nonconvergence as divergence for non-Cauchy termination (#754)

jpbrodrick89 · web-flow · commit 9094d0392fc9 · 2026-05-13T23:29:16.000+02:00
* fix reporting nonconvergence as divergence for non-Cauchy termination

* fix test
diff --git a/diffrax/_root_finder/_verychord.py b/diffrax/_root_finder/_verychord.py
@@ -162,7 +162,7 @@ def terminate(
         converged = _converged(factor, self.kappa)
         terminate = at_least_two & (small | diverged | converged)
         terminate_result = optx.RESULTS.where(
-            at_least_two & jnp.invert(small) & (diverged | jnp.invert(converged)),
+            at_least_two & jnp.invert(small) & diverged,
             optx.RESULTS.nonlinear_divergence,
             optx.RESULTS.successful,
         )
diff --git a/test/test_solver.py b/test/test_solver.py
@@ -50,7 +50,7 @@ def test_implicit_euler_adaptive():
         stepsize_controller=stepsize_controller,
         throw=False,
     )
-    assert out1.result == diffrax.RESULTS.nonlinear_divergence
+    assert out1.result == diffrax.RESULTS.nonlinear_max_steps_reached
     assert out2.result == diffrax.RESULTS.successful
 
 

Original file line number	Diff line number	Diff line change
`@@ -162,7 +162,7 @@ def terminate(`
`162`	`162`	`converged = _converged(factor, self.kappa)`
`163`	`163`	`terminate = at_least_two & (small \| diverged \| converged)`
`164`	`164`	`terminate_result = optx.RESULTS.where(`
`165`		`- at_least_two & jnp.invert(small) & (diverged \| jnp.invert(converged)),`
	`165`	`+ at_least_two & jnp.invert(small) & diverged,`
`166`	`166`	`optx.RESULTS.nonlinear_divergence,`
`167`	`167`	`optx.RESULTS.successful,`
`168`	`168`	`)`
Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ def test_implicit_euler_adaptive():`
`50`	`50`	`stepsize_controller=stepsize_controller,`
`51`	`51`	`throw=False,`
`52`	`52`	`)`
`53`		`- assert out1.result == diffrax.RESULTS.nonlinear_divergence`
	`53`	`+ assert out1.result == diffrax.RESULTS.nonlinear_max_steps_reached`
`54`	`54`	`assert out2.result == diffrax.RESULTS.successful`
`55`	`55`
`56`	`56`