Feature/cowork sandbox support#81
Open
mosi0815 wants to merge 7 commits into
Open
Conversation
…ting related references
- fix_cowork_sandbox_refs.nim: add patches E/F/G/H to omit sandbox/VM wording (path mapping, "files in sandbox", "Linux env boots in background", skill-scripts VM path) when running in native cowork mode - fix_computer_use_linux.nim: gate allowlist/screenshot wording on !__cuKwinMode so kwin-portal-bridge mode keeps upstream text; rework 14a "Separate filesystems" to flip only when native (no KVM, no bwrap) - fix_dispatch_linux.nim: comment out sessions-bridge gate + remote session control bypass (now EXPECTED_PATCHES=2) - fix_cowork_linux.nim: comment out Patch F (present_files host outputs dir) — EXPECTED_PATCHES=8 - Remove fix_cowork_first_bash.nim and fix_imagine_linux.nim - launcher: add --enable-experimental-web-platform-features for Bluetooth - bump .electron-version 42.0.0 → 42.0.1
Conflict resolution: - patches/fix_cowork_first_bash.nim: deleted (per branch WIP intent) - patches/fix_imagine_linux.nim: deleted (per branch WIP intent) - patches/fix_cowork_sandbox_refs.nim: combined master's v1.7196.1 patNew/patOld dual-pattern handling with the branch's 3-way KVM/sandbox/native ternary; both code paths now produce 3-way output. - patches/fix_dispatch_linux.nim: kept branch's intentionally commented-out Pt() flag overrides block; refreshed the dead jrPattern inside the comment with master's v1.7196 telemetry-aware regex so future revival sees the current pattern. Compiles cleanly (patches/make produces fix_cowork_sandbox_refs and fix_dispatch_linux binaries).
Both sub-patches anchored on hardcoded minified template-literal
variable names that shifted in v1.7196.1:
E (sandbox-file warning): ${AA} → ${eA} (second variant only;
first variant ${e} is unchanged).
F (path-mapping block): ${Ae}${EA}${W} → ${uA}${W}${IA};
${dA},${nA} → ${nA},${lA}.
Convert both from literal-substring matching to regex with [\w$]+
wildcards so future minification renames don't break them. The
replacement still preserves the original block verbatim (via m.match)
in kvm/sandbox modes and only substitutes the native-mode wording.
Verified end-to-end: ./scripts/build-local.sh against v1.7196.3 with
all 8 sub-patches now applying.
…box-support # Conflicts: # js/cowork_mode_preamble.js # patches/fix_cowork_linux.nim # patches/fix_imagine_linux.nim # scripts/claude-desktop-launcher.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks good to me. Detects the new sandbox mode and patches the tool descriptions accordingly.
And i disabled host loop mode again. couldnt reproduce any problem with it. Neither in kvm, sandbox or native mode.