Merge pull request #38 from patrickkabwe/fix/example-app

fix: center the open button

Author: patrickkabwe

android/src/main/java/com/nitroinappbrowser/HybridNitroInAppBrowser.kt

@@ -4,17 +4,21 @@ import com.margelo.nitro.NitroModules
 import com.margelo.nitro.core.Promise
 import com.margelo.nitro.nitroinappbrowser.HybridNitroInAppBrowserSpec
 import com.margelo.nitro.nitroinappbrowser.NitroInAppBrowserOptions
+import kotlinx.coroutines.MainScope
 
 class HybridNitroInAppBrowser: HybridNitroInAppBrowserSpec() {
     private val inAppBrowser = NitroInAppBrowserImpl(NitroModules.applicationContext)
+    private val scope = MainScope()
 
     override fun open(url: String, options: NitroInAppBrowserOptions?): Promise<Unit> {
-        return Promise.async {
+        return Promise.async(scope) {
             inAppBrowser.open(url, options)
         }
     }
 
-    override fun close() {
-        inAppBrowser.close()
+    override fun close(): Promise<Unit> {
+        return Promise.async(scope) {
+            inAppBrowser.close()
+        }
     }
 }

example/App.tsx

@@ -1,12 +1,12 @@
 import React from 'react';
-import {Button, SafeAreaView} from 'react-native';
+import {Button, SafeAreaView, StyleSheet} from 'react-native';
 import NitroInAppBrowser, {
   NitroInAppBrowserPresentationStyle,
 } from 'react-native-nitro-in-app-browser';
 
 const App = () => {
   return (
-    <SafeAreaView>
+    <SafeAreaView style={styles.container}>
       <Button
         title="Open Nowie Tech"
         onPress={async () => {
@@ -27,3 +27,11 @@ const App = () => {
 };
 
 export default App;
+
+const styles = StyleSheet.create({
+  container: {
+    flex: 1,
+    justifyContent: 'center',
+    alignItems: 'center',
+  },
+});

ios/HybridNitroInAppBrowser.swift

@@ -16,7 +16,7 @@ class HybridNitroInAppBrowser: HybridNitroInAppBrowserSpec {
             throw RuntimeError.error(withMessage: "Invalid URL")
         }
 
-        return Promise.async {
+        return .async {
             return try await withCheckedThrowingContinuation { continuation in
                 DispatchQueue.main.async { [weak self] in
                     do {
@@ -30,9 +30,11 @@ class HybridNitroInAppBrowser: HybridNitroInAppBrowserSpec {
         }
     }
 
-    func close() {
-        DispatchQueue.main.async { [weak self] in
-            self?.browserPresenter.dismiss()
+    func close() throws -> Promise<Void> {
+        return .async {
+            DispatchQueue.main.async { [weak self] in
+                self?.browserPresenter.dismiss()
+            }
         }
     }
 }