Skip to content

Commit 963ee5a

Browse files
committed
refactor: update close method to return Promise<Void> in iOS and Android implementations
1 parent 175d48b commit 963ee5a

9 files changed

Lines changed: 39 additions & 25 deletions

ios/HybridNitroInAppBrowser.swift

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ class HybridNitroInAppBrowser: HybridNitroInAppBrowserSpec {
1616
throw RuntimeError.error(withMessage: "Invalid URL")
1717
}
1818

19-
return Promise.async {
19+
return .async {
2020
return try await withCheckedThrowingContinuation { continuation in
2121
DispatchQueue.main.async { [weak self] in
2222
do {
@@ -30,9 +30,11 @@ class HybridNitroInAppBrowser: HybridNitroInAppBrowserSpec {
3030
}
3131
}
3232

33-
func close() {
34-
DispatchQueue.main.async { [weak self] in
35-
self?.browserPresenter.dismiss()
33+
func close() throws -> Promise<Void> {
34+
return .async {
35+
DispatchQueue.main.async { [weak self] in
36+
self?.browserPresenter.dismiss()
37+
}
3638
}
3739
}
3840
}

nitrogen/generated/android/c++/JHybridNitroInAppBrowserSpec.cpp

Lines changed: 14 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

nitrogen/generated/android/c++/JHybridNitroInAppBrowserSpec.hpp

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

nitrogen/generated/ios/NitroInAppBrowser-Swift-Cxx-Bridge.hpp

Lines changed: 0 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

nitrogen/generated/ios/c++/HybridNitroInAppBrowserSpecSwift.hpp

Lines changed: 3 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

nitrogen/generated/ios/swift/HybridNitroInAppBrowserSpec.swift

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

nitrogen/generated/ios/swift/HybridNitroInAppBrowserSpec_cxx.swift

Lines changed: 12 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

nitrogen/generated/shared/c++/HybridNitroInAppBrowserSpec.hpp

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/specs/nitro-in-app-browser.nitro.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,5 @@ import type { NitroInAppBrowserOptions } from '../types';
33
export interface NitroInAppBrowser
44
extends HybridObject<{ ios: 'swift'; android: 'kotlin' }> {
55
open(url: string, options?: NitroInAppBrowserOptions): Promise<void>
6-
close(): void
6+
close(): Promise<void>
77
}

0 commit comments

Comments
 (0)