chore(deps): bump up nitro to v0.28.1#104
Conversation
- Bump nitro-codegen and react-native-nitro-modules to version 0.28.1. - Update react-native-safe-area-context to version 5.6.1. - Update README.md to reflect the new version of react-native-nitro-modules. - Modify Swift-Cxx bridge methods to include noexcept for better error handling. - Update Podfile.lock to reflect changes in NitroInAppBrowser and NitroModules versions.
WalkthroughDocumentation updated to reflect a default export for NitroInAppBrowser and minor formatting tweaks. Development dependencies nitro-codegen and react-native-nitro-modules bumped from ^0.28.0 to ^0.28.1 in package.json. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
README.md (1)
34-46: Fix: using await in a non-async onPress handlerThe example uses
awaitinsideonPress={() => { ... }}which is not async and will fail. Mark the handler async.Apply this diff to correct the snippet:
- onPress={() => { + onPress={async () => { try { await NitroInAppBrowser.open('https://nowietech.com', { barColor: 'purple', controlColor: '#000000', dismissButtonLabel: 'close', presentationStyle: 'fullScreen', }); } catch (error) { console.error(error); } }}
🧹 Nitpick comments (2)
package.json (1)
71-75: Tighten peer dependency range for react-native-nitro-modulesGiven the dev toolchain now targets 0.28.1, allowing any version via "*" may let consumers install an older 0.27.x that’s incompatible at runtime/codegen time. Recommend expressing a compatible peer range.
Apply this diff to reflect a safe peer range:
"peerDependencies": { "react": "*", "react-native": "*", - "react-native-nitro-modules": "*" + "react-native-nitro-modules": "^0.28.1" },README.md (1)
18-20: Installation pin vs. range: consider using a caret or documenting compatibilityPinning to react-native-nitro-modules@0.28.1 is fine for reproducibility. If you intend to allow compatible patch updates, consider showing a caret range or add a note about supported versions.
Example:
bun install react-native-nitro-in-app-browser react-native-nitro-modules@^0.28.1Optionally, include npm/yarn equivalents for broader audience.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (6)
bun.lockis excluded by!**/*.lockexample/ios/Podfile.lockis excluded by!**/*.locknitrogen/generated/ios/NitroInAppBrowser-Swift-Cxx-Bridge.cppis excluded by!**/generated/**nitrogen/generated/ios/NitroInAppBrowser-Swift-Cxx-Bridge.hppis excluded by!**/generated/**nitrogen/generated/ios/swift/HybridNitroInAppBrowserSpec_cxx.swiftis excluded by!**/generated/**nitrogen/generated/ios/swift/NitroInAppBrowserOptions.swiftis excluded by!**/generated/**
📒 Files selected for processing (2)
README.md(4 hunks)package.json(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
README.md (2)
example/App.tsx (1)
NitroInAppBrowser(11-27)src/specs/nitro-in-app-browser.nitro.ts (1)
NitroInAppBrowser(3-7)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Build iOS Example App (old architecture)
- GitHub Check: Build iOS Example App (new architecture)
- GitHub Check: Build Android Example App (old architecture)
- GitHub Check: Build Android Example App (new architecture)
🔇 Additional comments (3)
package.json (1)
63-68: Dev dependency bumps to Nitro v0.28.1 look goodnitro-codegen and react-native-nitro-modules are aligned at ^0.28.1. Scripts still reference nitro-codegen, so this keeps toolchain consistent.
README.md (2)
40-41: String literal casing/typing looks consistentUsing 'fullScreen' matches the typical string union casing shown elsewhere. No action needed.
27-27: No changes required: default export confirmedThe
src/index.tsfile clearly includesexport default NitroInAppBrowseron line 17, so the README’s default import is correct.
1 participant
Summary by CodeRabbit
Documentation
Chores