chore: bump up rn version#146
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (12)
📝 WalkthroughWalkthroughConsolidates platform CI jobs into single build jobs, removes old-architecture toggles, updates example app manifests and build settings, bumps React/React Native and related tooling, refactors Android MainApplication to lazy ReactHost initialization, and adjusts TypeScript config and minor docs text. (50 words) Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (3)
example/package.json (1)
34-34: Node >= 22.11.0 is a significant requirement bump.Jumping from Node >=18 to >= 22.11.0 may break CI pipelines or developer environments not yet on Node 22. The specific patch version (22.11.0) suggests this might be tied to a specific feature requirement—consider documenting why this exact version is needed.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@example/package.json` at line 34, The package.json engines field currently pins "node": ">= 22.11.0", which is a large, potentially breaking bump; either relax or justify it: update the engines entry (engines.node) to a less strict range (e.g., ">=18" or ">=18 <25") if no 22.11-only feature is required, or keep the 22.11.0 requirement but add a short explanation in the README and a CI note describing which Node feature/bugfix necessitates 22.11.0 and instructions for developers to upgrade their environments; reference the package.json engines.node field when making the change and ensure CI configs (e.g., .github/workflows) are updated to match..github/workflows/ios-build.yml (1)
63-63: Consider updating Ruby version.Ruby 2.7.2 reached end-of-life in March 2023. While it may still work, consider upgrading to a supported Ruby version (e.g., 3.1.x or 3.2.x) to avoid potential security issues and ensure long-term compatibility.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/ios-build.yml at line 63, The workflow pins ruby-version: 2.7.2 which is EOL; update the ruby-version key in the GitHub Actions workflow (.github/workflows/ios-build.yml) to a supported release like "3.2.x" or "3.1.x" (or a specific patch such as "3.2.2"), then run CI to confirm compatibility and adjust any Ruby-dependent steps or Gemfile/RubyGems versions if tests or bundler fail; search for the ruby-version entry to locate where to change it.example/ios/NitroInAppBrowserExample.xcodeproj/project.pbxproj (1)
395-395: Add a comment explaining the Xcode 26 compatibility requirement.
SWIFT_ENABLE_EXPLICIT_MODULES = NOis necessary to resolve React Native compatibility issues with Xcode 26, where explicit Swift modules cause module resolution failures. Consider adding a comment in the project (e.g., in the project file or Xcode build settings UI) documenting this requirement for future maintainers. For projects on React Native 0.83+, this may be handled automatically; otherwise, ensure this setting is applied to all build targets that interact with React Native.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@example/ios/NitroInAppBrowserExample.xcodeproj/project.pbxproj` at line 395, Add a brief inline comment near the SWIFT_ENABLE_EXPLICIT_MODULES = NO setting explaining it’s required for Xcode 26 compatibility with React Native (explicit Swift modules can cause module resolution failures), and ensure the comment notes that RN >=0.83 may handle this automatically and that the setting should be applied to all build targets interacting with React Native (update the project.pbxproj entry containing SWIFT_ENABLE_EXPLICIT_MODULES and any target build settings references).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@example/android/app/src/main/AndroidManifest.xml`:
- Line 12: The manifest uses the placeholder ${usesCleartextTraffic} which is
not defined, causing build failures; add a manifestPlaceholders entry in the
Gradle config by updating android.defaultConfig to include manifestPlaceholders
= [usesCleartextTraffic: "false"] (or "true" as appropriate) so the
AndroidManifest.xml placeholder is resolved; modify the module build.gradle
(inside android.defaultConfig) to declare the usesCleartextTraffic manifest
placeholder.
---
Nitpick comments:
In @.github/workflows/ios-build.yml:
- Line 63: The workflow pins ruby-version: 2.7.2 which is EOL; update the
ruby-version key in the GitHub Actions workflow
(.github/workflows/ios-build.yml) to a supported release like "3.2.x" or "3.1.x"
(or a specific patch such as "3.2.2"), then run CI to confirm compatibility and
adjust any Ruby-dependent steps or Gemfile/RubyGems versions if tests or bundler
fail; search for the ruby-version entry to locate where to change it.
In `@example/ios/NitroInAppBrowserExample.xcodeproj/project.pbxproj`:
- Line 395: Add a brief inline comment near the SWIFT_ENABLE_EXPLICIT_MODULES =
NO setting explaining it’s required for Xcode 26 compatibility with React Native
(explicit Swift modules can cause module resolution failures), and ensure the
comment notes that RN >=0.83 may handle this automatically and that the setting
should be applied to all build targets interacting with React Native (update the
project.pbxproj entry containing SWIFT_ENABLE_EXPLICIT_MODULES and any target
build settings references).
In `@example/package.json`:
- Line 34: The package.json engines field currently pins "node": ">= 22.11.0",
which is a large, potentially breaking bump; either relax or justify it: update
the engines entry (engines.node) to a less strict range (e.g., ">=18" or ">=18
<25") if no 22.11-only feature is required, or keep the 22.11.0 requirement but
add a short explanation in the README and a CI note describing which Node
feature/bugfix necessitates 22.11.0 and instructions for developers to upgrade
their environments; reference the package.json engines.node field when making
the change and ensure CI configs (e.g., .github/workflows) are updated to match.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 5f48d313-4676-4acb-b4d0-cae9b30004c3
⛔ Files ignored due to path filters (3)
bun.lockis excluded by!**/*.lockexample/android/gradle/wrapper/gradle-wrapper.jaris excluded by!**/*.jarexample/ios/Podfile.lockis excluded by!**/*.lock
📒 Files selected for processing (14)
.github/workflows/android-build.yml.github/workflows/ios-build.ymlREADME.mdexample/android/app/src/debug/AndroidManifest.xmlexample/android/app/src/main/AndroidManifest.xmlexample/android/app/src/main/java/com/nitroinappbrowserexample/MainApplication.ktexample/android/gradle/wrapper/gradle-wrapper.propertiesexample/android/gradlewexample/ios/NitroInAppBrowserExample.xcodeproj/project.pbxprojexample/ios/NitroInAppBrowserExample/Info.plistexample/package.jsonexample/tsconfig.jsonpackage.jsonsrc/specs/nitro-in-app-browser.nitro.ts
💤 Files with no reviewable changes (1)
- example/android/app/src/debug/AndroidManifest.xml
patrickkabwe
force-pushed
the
chore/bump-up-rn-version
branch
from
b84643c to
809ef4c
Compare
patrickkabwe
force-pushed
the
chore/bump-up-rn-version
branch
from
809ef4c to
9c203aa
Compare
|
🎉 This PR is included in version 2.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
1 participant
Summary by CodeRabbit
Chores
Documentation