fix(ios): dismiss selection when tapping outside textview

Author: patrickkabwe

bun.lock

@@ -0,0 +1,2 @@
+[install]
+linker = "hoisted"

bunfig.toml

@@ -8,7 +8,7 @@ PODS:
   - hermes-engine (0.81.4):
     - hermes-engine/Pre-built (= 0.81.4)
   - hermes-engine/Pre-built (0.81.4)
-  - NitroModules (0.29.6):
+  - NitroModules (0.30.0):
     - boost
     - DoubleConversion
     - fast_float
@@ -37,7 +37,7 @@ PODS:
     - ReactCommon/turbomodule/core
     - SocketRocket
     - Yoga
-  - NitroText (1.0.2):
+  - NitroText (1.0.3):
     - boost
     - DoubleConversion
     - fast_float
@@ -2643,8 +2643,8 @@ SPEC CHECKSUMS:
   fmt: a40bb5bd0294ea969aaaba240a927bd33d878cdd
   glog: 5683914934d5b6e4240e497e0f4a3b42d1854183
   hermes-engine: 35c763d57c9832d0eef764316ca1c4d043581394
-  NitroModules: 7d693306799405ca141ef5c24efc0936f20a09c0
-  NitroText: 1f69b7c0c89d9f7cbf35fb8cf114dc6ecf8981a6
+  NitroModules: dae5a0f5867aa19ca3222084519c30cb6ca0280a
+  NitroText: c95604214333634a6a083ac7211b238686dbd628
   RCT-Folly: 846fda9475e61ec7bcbf8a3fe81edfcaeb090669
   RCTDeprecation: c0ed3249a97243002615517dff789bf4666cf585
   RCTRequired: 58719f5124f9267b5f9649c08bf23d9aea845b23

example/ios/Podfile.lock

@@ -14,7 +14,7 @@
     "react": "19.1.0",
     "react-native": "0.81.4",
     "react-native-safe-area-context": "^5.5.2",
-    "react-native-nitro-modules": "^0.29.6"
+    "react-native-nitro-modules": "^0.30.0"
   },
   "devDependencies": {
     "@babel/core": "^7.25.2",

example/package.json

@@ -19,6 +19,7 @@ final class NitroTextView: UITextView {
     var tkLayoutManager: NSLayoutManager?
     weak var nitroTextDelegate: NitroTextViewDelegate?
     private var tapRecognizer: UITapGestureRecognizer?
+    private weak var windowTapRecognizer: UITapGestureRecognizer?
 
     override init(frame: CGRect, textContainer: NSTextContainer?) {
         if let provided = textContainer {
@@ -37,6 +38,10 @@ final class NitroTextView: UITextView {
         setupView()
     }
 
+    deinit {
+        removeWindowTapRecognizer()
+    }
+
     private func setupView() {
         isEditable = false
         isSelectable = false
@@ -46,6 +51,7 @@ final class NitroTextView: UITextView {
         textContainerInset = .zero
         textContainer.lineFragmentPadding = 0
         layoutManager.usesFontLeading = false
+        textColor = .black
         contentInset = .zero
         clipsToBounds = true
 
@@ -78,6 +84,11 @@ final class NitroTextView: UITextView {
         }
     }
 
+    override func didMoveToWindow() {
+        super.didMoveToWindow()
+        updateWindowTapRecognizer()
+    }
+
     override func touchesBegan(_ touches: Set<UITouch>, with event: UIEvent?) {
         super.touchesBegan(touches, with: event)
         nitroTextDelegate?.onNitroTextPressIn()
@@ -168,9 +179,22 @@ final class NitroTextView: UITextView {
         nitroTextDelegate?.onNitroTextPress()
     }
 
+    @objc private func handleWindowTap(_ recognizer: UITapGestureRecognizer) {
+        guard recognizer === windowTapRecognizer, recognizer.state == .ended else { return }
+        guard hasActiveSelection() else { return }
+        let location = recognizer.location(in: self)
+        if point(inside: location, with: nil) { return }
+        selectedTextRange = nil
+    }
+
 }
 
 private extension NitroTextView {
+    func hasActiveSelection() -> Bool {
+        guard let currentSelection = selectedTextRange else { return false }
+        return selectionLength(currentSelection) > 0
+    }
+
     func selectionLength(_ range: UITextRange) -> Int {
         offset(from: range.start, to: range.end)
     }
@@ -192,4 +216,44 @@ private extension NitroTextView {
             selectedTextRange = nil
         }
     }
+
+    func updateWindowTapRecognizer() {
+        guard let window = window else {
+            removeWindowTapRecognizer()
+            return
+        }
+
+        if let recognizer = windowTapRecognizer, recognizer.view !== window {
+            removeWindowTapRecognizer()
+        }
+
+        if windowTapRecognizer == nil {
+            let recognizer = UITapGestureRecognizer(target: self, action: #selector(handleWindowTap(_:)))
+            recognizer.cancelsTouchesInView = false
+            recognizer.delegate = self
+            window.addGestureRecognizer(recognizer)
+            windowTapRecognizer = recognizer
+        }
+    }
+
+    func removeWindowTapRecognizer() {
+        guard let recognizer = windowTapRecognizer else { return }
+        recognizer.view?.removeGestureRecognizer(recognizer)
+        windowTapRecognizer = nil
+    }
+}
+
+extension NitroTextView: UIGestureRecognizerDelegate {
+    func gestureRecognizer(_ gestureRecognizer: UIGestureRecognizer, shouldReceive touch: UITouch) -> Bool {
+        guard gestureRecognizer === windowTapRecognizer else { return true }
+        guard hasActiveSelection() else { return false }
+        guard let touchedView = touch.view else { return true }
+        if touchedView === self { return false }
+        if touchedView.isDescendant(of: self) { return false }
+        return true
+    }
+
+    func gestureRecognizer(_ gestureRecognizer: UIGestureRecognizer, shouldRecognizeSimultaneouslyWith otherGestureRecognizer: UIGestureRecognizer) -> Bool {
+        gestureRecognizer === windowTapRecognizer
+    }
 }