fix(ios): nested NitroText numberOfLines renders only one line#15
Closed
patrickkabwe wants to merge 4 commits intomainfrom
Closed
fix(ios): nested NitroText numberOfLines renders only one line#15patrickkabwe wants to merge 4 commits intomainfrom
patrickkabwe wants to merge 4 commits intomainfrom
Conversation
…berOfLines\n\n- Use tail truncation for multi-line, clip wraps; avoid head/middle for n>1\n- Prevents single-line collapse when composing parent+child fragments\n- Aligns closer to RN Text behavior in nested scenarios
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where nested NitroText with numberOfLines would display only the first line.\n\nChanges\n- Multi-line truncation now coerces to tail or wrap+clip, avoiding head/middle for n>1\n- Ensures composed parent+child fragments layout to the correct multi-line height\n\nWhy\n- iOS only reliably supports tail/clip for multi-line; head/middle can collapse layout to a single line, especially with composed attributed strings.\n\nTest Plan\n- In example/App.tsx, nest a NitroText inside another with numberOfLines={2}\n- Verify both parent literal and inner content render across two lines with tail ellipsis (or wrap+clip) rather than collapsing to one line.