Skip to content

Add customisable note#2

Open
michalkleiner wants to merge 12 commits into
patricknelson:masterfrom
chrometoasters:customisable_note
Open

Add customisable note#2
michalkleiner wants to merge 12 commits into
patricknelson:masterfrom
chrometoasters:customisable_note

Conversation

@michalkleiner

Copy link
Copy Markdown

No description provided.

@patricknelson

patricknelson commented Dec 17, 2016

Copy link
Copy Markdown
Owner

Hi, sorry for letting this rot. I think it had a few issues at first but never came back to check up on it. Looks like this still needs to get done:

  • Update your local copy with what's currently in master to resolve any conflicts. After this, there may be more changes needed after review (very difficult to read and interpret changes). It should help that I've updated from tabs to spaces (better standard anyway).
  • For the auto-completer: Please set that up as a separate option (i.e. removeAutocompleter with a setter and default it to true).

Thank you very much for the contributions!

@@ -0,0 +1,53 @@
<?php

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: Test this once merged.

@michalkleiner

Copy link
Copy Markdown
Author

Hi, sorry, didn't have much time too, hopefully I'll manage to get this done soon, as it's also annoying for us to use custom fork's branch instead of the module's main one in composer.json :-D

@patricknelson

Copy link
Copy Markdown
Owner

Yeah -- and good on you for having that motivation. That's the same reason why submit a PR to SS core (framework/cms) whenever I can if I absolutely must make a core modification. Even then, I avoid having to modify core like the plague due to the (albeit necessary) standards.

@patricknelson

Copy link
Copy Markdown
Owner

Bump.

@michalkleiner

Copy link
Copy Markdown
Author

Bump received! Let me see what I can do in next few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants