Fix log/symlog tick positions and compute linthresh from data#1
Closed
patrickoleary wants to merge 197 commits intomasterfrom
Closed
Fix log/symlog tick positions and compute linthresh from data#1patrickoleary wants to merge 197 commits intomasterfrom
patrickoleary wants to merge 197 commits intomasterfrom
Conversation
Owner
patrickoleary
commented
Apr 24, 2026
patrickoleary
commented
- Compute linthresh from min abs non-zero value in data array (zero-copy, vectorized O(n))
- Fix symlog function to standard formulation: sign(v) * log10(1 + |v|/linthresh)
- Fix log tick positions to use log-normalized positions on linear colorbar
- Fix symlog tick values to use powers of 10 matching LUT breakpoints
- Capture linear colorbar image before any log/symlog LUT transforms
- Pass linthresh once from data through all functions that need it
- Add tooltips to file browser buttons - Add slider/text-input toggle to DataSelection toolbar - Style hotkey badges with rounded borders - Add primary outline to active drawer toggle buttons - Fix tooltips for color config card Resolves Kitware#44
…Input min/max syntax
Default animation_track to None instead of "timestamps" to avoid crashing at startup before any file is loaded. Also guard against empty state values in the track change handler.
Dimensions that lack coordinate variables (e.g., ext_cnt, num_gas_aerosol_constituents) now appear in the slice selection UI with index-based sliders. Labels show the actual units when a coordinate variable exists, or "Index value:" otherwise.
Replace flatten() with reshape(-1) to avoid copies where the data is only read. In _load_variable, use a single copy followed by in-place fill value replacement instead of flatten + np.where which created three copies.
Track which dimensions changed in SetSlicing and only reload variables whose dimensions intersect the changed set. Variables unaffected by the slice change are kept from the previous output. For example, changing lev now skips all 2D (time, ncol) variables. With 200 2D + 20 3D variables loaded, lev changes are ~2.5x faster.
Only copy and scan for fill values when the variable actually has a _FillValue attribute. Most variables default to NaN, making the comparison a no-op that still scans the entire array. Variables without fill values now return a zero-copy view from reshape.
… LUT preset application order
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.