finish coverage for data link issue

closes #653

Author: bmuenzenmeyer

core/lib/patternlab.js

@@ -24,6 +24,8 @@ var diveSync = require('diveSync'),
   jsonCopy = require('./json_copy'),
   ui = require('./ui_builder'),
   ui_builder = new ui(),
+  pe = require('./pattern_exporter'),
+  pattern_exporter = new pe(),
   PatternGraph = require('./pattern_graph').PatternGraph;
 
 //register our log events
@@ -150,7 +152,6 @@ var patternlab_engine = function (config) {
   'use strict';
 
   var pa = require('./pattern_assembler'),
-    pe = require('./pattern_exporter'),
     lh = require('./lineage_hunter'),
     sm = require('./starterkit_manager'),
     Pattern = require('./object_factory').Pattern,
@@ -160,7 +161,6 @@ var patternlab_engine = function (config) {
   patternlab.engines = patternEngines;
 
   var pattern_assembler = new pa(),
-    pattern_exporter = new pe(),
     lineage_hunter = new lh();
 
   patternlab.package = fs.readJSONSync(path.resolve(__dirname, '../../package.json'));
@@ -581,7 +581,6 @@ var patternlab_engine = function (config) {
       }
     }
 
-
     //render all patterns last, so lineageR works
     patternsToBuild.forEach(pattern => renderSinglePattern(pattern, head));
 

test/files/_patterns/00-test/paramMiddle.mustache

@@ -1,3 +1,3 @@
 <div class="{{styleModifier}}">
-  {{> test-nav }}
+  {{> test-link }}
 </div>

test/files/_patterns/00-test/paramParent.json

@@ -1,11 +1,3 @@
 {
-  "brad" : {
-    "url" : "link.twitter-brad"
-  },
-  "dave" : {
-    "url" : "link.twitter-dave"
-  },
-  "brian" : {
-    "url" : "link.twitter-brian"
-  }
+  "url" : "link.test-foo"
 }

test/patternlab_tests.js

@@ -1,47 +1,73 @@
 'use strict';
 
-var tap = require('tap');
-var rewire = require("rewire");
+const tap = require('tap');
+const rewire = require("rewire");
+const _ = require('lodash');
+const fs = require('fs-extra');
 var config = require('./util/patternlab-config.json');
 
 var plEngineModule = rewire('../core/lib/patternlab');
 
 //set up a global mocks - we don't want to be writing/rendering any files right now
-var uiBuilderMock = {
+const uiBuilderMock = {
   buildFrontend: function (patternlab) { }
 };
 
+const fsMock = {
+  outputFileSync: function (path, content) { /* INTENTIONAL NOOP */},
+  readJSONSync: function(path, encoding) {
+    return fs.readJSONSync(path, encoding);
+  },
+  removeSync: function(path) { fs.removeSync(path); },
+  emptyDirSync: function(path) { fs.emptyDirSync(path); },
+  readFileSync: function(path, encoding) { return fs.readFileSync(path, encoding); },
+}
+
 //set our mocks in place of usual require()
 plEngineModule.__set__({
-  'ui_builder': uiBuilderMock
+  'ui_builder': uiBuilderMock,
+  'fs': fsMock
 });
 
-var pl = new plEngineModule(config);
-
+tap.test('buildPatternData - should merge all JSON files in the data folder except listitems', function(test){
+  var data_dir = './test/files/_data/';
 
-// tap.test('buildPatternData - should merge all JSON files in the data folder except listitems', function(test){
-//   var fs = require('fs-extra');
-//   var plMain = require('../core/lib/patternlab');
-//   var data_dir = './test/files/_data/';
-//
-//   var dataResult = plMain.build_pattern_data(data_dir, fs);
-//   test.equals(dataResult.data, "test");
-//   test.equals(dataResult.foo, "bar");
-//   test.equals(dataResult.test_list_item, undefined);
-//   test.end();
-// });
+  var dataResult = plEngineModule.build_pattern_data(data_dir, fs);
+  test.equals(dataResult.data, "test");
+  test.equals(dataResult.foo, "bar");
+  test.equals(dataResult.test_list_item, undefined);
+  test.end();
+});
 
 tap.test('buildPatterns - should replace data link even when pattern parameter present', function(test) {
   //arrange
 
+  var patternExporterMock = {
+    /*
+     In this test, we actually take advantage of the pattern export functionality post-build to inspect what
+     the contents of the patterns look like. This, coupled with a mocking of fs and the ui_builder, allow us to focus
+     only on the order of events within build.
+     */
+    export_patterns: function (patternlab) {
+      var pattern = _.find(patternlab.patterns, (pattern) => {
+        return pattern.patternPartial === 'test-paramParent';
+      });
+      //assert
+      test.equals(pattern.patternPartialCode.indexOf('00-test-00-foo.rendered.html') > -1, true, 'data link should be replaced properly');
+    }
+  };
+
+  plEngineModule.__set__({
+    'pattern_exporter': patternExporterMock
+  });
+
+  config.patternExportPatternPartials = ['test-paramParent'];
+  var pl = new plEngineModule(config);
+
   //act
   pl.build(function() {
-
-    test.equals(1,1);
     test.end();
-
   }, true);
 
-  //assert
 
 });

test/util/patternlab-config.json

@@ -62,5 +62,6 @@
     "markupOnly": ".markup-only"
   },
   "cleanOutputHtml": true,
-  "exportToGraphViz": false
+  "exportToGraphViz": false,
+  "cleanPublic": true
 }