converted media_hunter into a more unit testable function

Author: bmuenzenmeyer

builder/media_hunter.js

@@ -17,10 +17,10 @@
 
 	var media_hunter = function(){
 
-		function findMediaQueries(patternlab){
+		function findMediaQueries(dir, patternlab){
 			patternlab.mediaQueries = [];
 
-			diveSync('./source/css', function(err, file){
+			diveSync(dir, function(err, file){
 				if(path.extname(file) === '.css'){
 					var contents = fs.readFileSync(file, 'utf8');
 					var safeContents = contents.replace("\r", " ").replace("\n", " ");
@@ -38,8 +38,8 @@
 		}
 
 		return {
-			find_media_queries: function(patternlab){
-				findMediaQueries(patternlab);
+			find_media_queries: function(dir, patternlab){
+				findMediaQueries(dir, patternlab);
 			}
 		};
 

builder/parameter_hunter.js

@@ -1,10 +1,10 @@
-/*
- * patternlab-node - v0.10.0 - 2015
- *
+/* 
+ * patternlab-node - v0.10.0 - 2015 
+ * 
  * Brian Muenzenmeyer, and the web community.
- * Licensed under the MIT license.
- *
- * Many thanks to Brad Frost and Dave Olsen for inspiration, encouragement, and advice.
+ * Licensed under the MIT license. 
+ * 
+ * Many thanks to Brad Frost and Dave Olsen for inspiration, encouragement, and advice. 
  *
  */
 

builder/patternlab.js

@@ -113,7 +113,7 @@ var patternlab_engine = function () {
     patternlab.viewAllPaths = {};
 
     //find mediaQueries
-    media_hunter.find_media_queries(patternlab);
+    media_hunter.find_media_queries('./source/css', patternlab);
 
     //build the styleguide
     var styleguideTemplate = fs.readFileSync('./source/_patternlab-files/styleguide.mustache', 'utf8'),

test/files/test.css

@@ -0,0 +1,13 @@
+@media only screen and (min-width: 35em){
+    body{
+      color: rebeccapurple;
+    }
+}
+
+@media (min-width:50em){ body{ color: grey;} }
+
+@media only screen and (min-width: 70em) and (max-width: 1600px){
+  body{
+    color: green;
+  }
+}

test/media_hunter_tests.js

@@ -4,7 +4,7 @@
 	var MediaHunter = require('../builder/media_hunter');
 
 	//all tests here run against the shipped code, and as such altering any of that can break these tests
-	//these tests are intended to catch development regressions. one should not have a need to run tests during patternlab use. 
+	//these tests are intended to catch development regressions. one should not have a need to run tests during patternlab use.
 
 	exports['media_query hunter basic support '] = {
 		'test media hunter finds query' : function(test){
@@ -13,52 +13,40 @@
 			var pl = {};
 			var mh = new MediaHunter();
 
-			mh.find_media_queries(pl);
+			mh.find_media_queries('./test/files', pl);
 
-			test.equals(pl.mediaQueries.length, 7);
+			test.equals(pl.mediaQueries.length, 4);
 
 			test.done();
-		}
-	};
+		},
 
-	exports['media_query hunter spaces '] = {
 		'test media hunter supports spaces in media query' : function(test){
 
 			//setup pl object
 			var pl = {};
 			var mh = new MediaHunter();
 
-			mh.find_media_queries(pl);
+			mh.find_media_queries('./test/files', pl);
+
+			test.equals(pl.mediaQueries[0], '1600px');
 
-			test.equals(pl.mediaQueries[0], '24em');
+			console.log(pl.mediaQueries);
 
 			test.done();
-		}
-	};
+		},
 
-	exports['media_query hunter no spaces '] = {
 		'test media hunter supports nospaces in media query' : function(test){
 
 			//setup pl object
 			var pl = {};
 			var mh = new MediaHunter();
 
-			mh.find_media_queries(pl);
-
-			//the last media query found in the shipped suite does not have a space
-			//you can see this here:
+			mh.find_media_queries('./test/files', pl);
 
-			//./source/css/scss/base/_global-classes.scss
-			// .hide-large-2 {
-			//     @media all and (min-width:$bp-large-2) {
-			//         display: none;
-			//     }
-			// }
- 
-			test.equals(pl.mediaQueries[6], '66em');
+			test.equals(pl.mediaQueries[2], '50em');
 
 			test.done();
 		}
 	};
 
-}());
+}());