Skip to content

Commit 6e3fa43

Browse files
committed
update test assertions
1 parent 1827b2b commit 6e3fa43

3 files changed

Lines changed: 26 additions & 23 deletions

File tree

packages/module/src/AttachmentEdit/AttachmentEdit.test.tsx

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { fireEvent, render, screen } from '@testing-library/react';
1+
import { fireEvent, render, screen, within } from '@testing-library/react';
22
import '@testing-library/jest-dom';
33
import AttachmentEdit, { AttachmentEditProps } from './AttachmentEdit';
44

@@ -67,8 +67,8 @@ describe('AttachmentEdit', () => {
6767
/>
6868
);
6969

70-
screen.getByText('Save');
71-
screen.getByText('Close');
70+
expect(screen.getByText('Save')).toBeInTheDocument();
71+
expect(screen.getByText('Close')).toBeInTheDocument();
7272
});
7373

7474
it('should render AttachmentEdit with custom classNames', async () => {
@@ -88,11 +88,12 @@ describe('AttachmentEdit', () => {
8888
></AttachmentEdit>
8989
);
9090

91-
const modalHeader = document.querySelector('header.custom-header-class');
92-
expect(modalHeader).toBeInTheDocument();
93-
const modalBody = document.querySelector('.custom-body-class');
94-
expect(modalBody).toBeInTheDocument();
95-
const modalfooter = document.querySelector('.custom-footer-class');
96-
expect(modalfooter).toBeInTheDocument();
91+
const modal = screen.getByRole('dialog');
92+
const modalHeader = within(modal).getByRole('banner');
93+
expect(modalHeader).toHaveClass('custom-header-class');
94+
const modalBody = modal.querySelector('#code-modal-body');
95+
expect(modalBody).toHaveClass('custom-body-class');
96+
const modalfooter = within(modal).getByRole('contentinfo');
97+
expect(modalfooter).toHaveClass('custom-footer-class');
9798
});
9899
});

packages/module/src/CodeModal/CodeModal.test.tsx

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { render, screen } from '@testing-library/react';
1+
import { render, screen, within } from '@testing-library/react';
22
import '@testing-library/jest-dom';
33
import CodeModal from './CodeModal';
44

@@ -40,11 +40,12 @@ describe('ChatbotModal', () => {
4040
></CodeModal>
4141
);
4242

43-
const modalHeader = document.querySelector('header.custom-header-class');
44-
expect(modalHeader).toBeInTheDocument();
45-
const modalBody = document.querySelector('.custom-body-class');
46-
expect(modalBody).toBeInTheDocument();
47-
const modalfooter = document.querySelector('.custom-footer-class');
48-
expect(modalfooter).toBeInTheDocument();
43+
const modal = screen.getByRole('dialog');
44+
const modalHeader = within(modal).getByRole('banner');
45+
expect(modalHeader).toHaveClass('custom-header-class');
46+
const modalBody = modal.querySelector('#code-modal-body');
47+
expect(modalBody).toHaveClass('custom-body-class');
48+
const modalfooter = within(modal).getByRole('contentinfo');
49+
expect(modalfooter).toHaveClass('custom-footer-class');
4950
});
5051
});

packages/module/src/PreviewAttachment/PreviewAttachment.test.tsx

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { fireEvent, render, screen } from '@testing-library/react';
1+
import { fireEvent, render, screen, within } from '@testing-library/react';
22
import '@testing-library/jest-dom';
33
import { PreviewAttachment } from './PreviewAttachment';
44

@@ -82,11 +82,12 @@ describe('PreviewAttachment', () => {
8282
></PreviewAttachment>
8383
);
8484

85-
const modalHeader = document.querySelector('header.custom-header-class');
86-
expect(modalHeader).toBeInTheDocument();
87-
const modalBody = document.querySelector('.custom-body-class');
88-
expect(modalBody).toBeInTheDocument();
89-
const modalfooter = document.querySelector('.custom-footer-class');
90-
expect(modalfooter).toBeInTheDocument();
85+
const modal = screen.getByRole('dialog');
86+
const modalHeader = within(modal).getByRole('banner');
87+
expect(modalHeader).toHaveClass('custom-header-class');
88+
const modalBody = modal.querySelector('#code-modal-body');
89+
expect(modalBody).toHaveClass('custom-body-class');
90+
const modalfooter = within(modal).getByRole('contentinfo');
91+
expect(modalfooter).toHaveClass('custom-footer-class');
9192
});
9293
});

0 commit comments

Comments
 (0)