fix(MessageBar): updated padding on action buttons#773
Conversation
|
Preview: https://chatbot-pr-chatbot-773.surge.sh A11y report: https://chatbot-pr-chatbot-773-a11y.surge.sh |
There was a problem hiding this comment.
Inline looks better to me, but it still looks funky on multi-line! (Looking at https://chatbot-pr-chatbot-773.surge.sh/extensions/chatbot/overview/demo/compact-chatbot/)
|
@kaylachumley wdyt about the above screenshot? The Send button now gets pretty close to the border of the message bar when things wrap in the input area. I pushed an update to help resolve this, there were some styles that didn't look to be applied right. Went with small spacers top and bottom; you can test it out in the compact demo and entering new lines in the message bar input field |
thatblindgeye
force-pushed
the
iss767
branch
from
7b00849 to
61e8b70
Compare
rebeccaalpert
left a comment
rebeccaalpert
left a comment
There was a problem hiding this comment.
Looks good to me; thank you!
kaylachumley
left a comment
kaylachumley
left a comment
There was a problem hiding this comment.
hmmm okay i was tinkering with the spacing and im wondering if it would be best to just change the border radius of the entire message bar when its 2 or more lines of text to be 6px vs the 16px. That would fix the message actions from being too close to the edge. WDYT? @andrew-ronaldson
|
I agree with your border-radius idea Kayla. That full pill is fine as the default but as soon was it stretches things get wonky. |
|
🎉 This PR is included in version 6.5.0-prerelease.24 🎉 The release is available on: Your semantic-release bot 📦🚀 |
6 participants
Closes #767