Skip to content

Commit 042b602

Browse files
committed
fix: refine
1 parent 739d80d commit 042b602

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

guidelines/skills/review-zod-integration/SKILL.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
22
name: review-zod-integration
3-
description: Reviews Zod dependency upgrades for PatternFly MCP—maps release notes to codebase usage, runs tests, and writes a dated update report with impact tables and prioritized fixes. Use when bumping zod, reviewing zod integration, assessing Zod breaking changes, generating a zod update report, or reviewing Dependabot/Renovate zod PRs.
3+
description: Reviews Zod dependency upgrades for PatternFly MCP—maps release notes to codebase usage, runs tests, and writes a dated update report with impact tables and prioritized fixes. Use when bumping zod, on review zod, zod upgrade, zod integration review, assessing Zod breaking changes, generating a zod update report, or reviewing Dependabot/Renovate zod PRs.
44
---
55

66
# Review Zod Integration (PatternFly MCP)

guidelines/skills/review-zod-integration/reference.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ If release notes only mention these, impact is usually **None**:
7070
| `zod` | Direct production dep; use native `fromJSONSchema` / `toJSONSchema` (not `zod-to-json-schema` in app code) |
7171
| `@modelcontextprotocol/sdk` | Depends on / peers `zod ^3.25 \|\| ^4.0` |
7272

73-
## Audit Depth Policy
73+
## Audit depth policy
7474

7575
| Source | Frequency | Objective |
7676
| :--- | :--- | :--- |
@@ -271,19 +271,19 @@ No release-note item maps to APIs used in PF MCP hot paths; unit, e2e, and audit
271271

272272
## Architecture
273273

274-
### SDK Routing Trigger
274+
### SDK routing trigger
275275
The MCP SDK requires `inputSchema` to be a Zod instance to route `(args, context)` to tool handlers. We rehydrate minimal Zod in the parent process (via `normalizeInputSchema`) specifically to trigger this signature, while keeping genuine validation in the isolated child process.
276276

277-
## Compatibility Policy (Zod Detection)
277+
## Compatibility policy (Zod detection)
278278

279279
To support a diverse plugin ecosystem, PatternFly MCP maintains a "Compatibility-First" approach for Zod schema detection.
280280

281-
### Preservation Rules:
281+
### Preservation rules
282282
1. **Never Remove `_def` Detection**: Even when pinned to Zod 4+, the `isZodSchema` function in `src/server.schema.ts` must keep the `_def` check to support plugins using Zod v3.
283283
2. **Additive Detection**: When Zod introduces new public APIs (like `.def` in v4.4), add detection for them *alongside* existing internal brands (`_zod`, `_def`).
284284
3. **Exceptions**: Legacy detection should only be removed if the Zod release notes indicate that a legacy property (e.g., `_def`) has been repurposed in a way that causes false positives or crashes in the current version.
285285

286-
### Updated P2 Recommendations (Recurring):
286+
### Updated P2 recommendations (recurring)
287287
These items MUST be included in the "Recommended Fixes (P2)" section of the report for any Zod 4.4+ review to ensure long-term health, even if they are not strictly required for the current bump to "pass."
288288

289289
- **DO**: Add detection for the public `.def` property (Zod 4.4+).

0 commit comments

Comments
 (0)