Skip to content

Commit 0bf6bae

Browse files
committed
fix: review updates
1 parent b92bcf1 commit 0bf6bae

4 files changed

Lines changed: 8 additions & 7 deletions

File tree

src/options.defaults.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,6 @@ interface ModeOptions {
176176
*/
177177
interface PatternFlyOptions {
178178
availableResourceVersions: ('6.0.0')[];
179-
// availableSearchVersions: ('current' | 'detected' | 'latest' | 'v3' | 'v4' | 'v5' | 'v6')[];
180179
availableSearchVersions: ('current' | 'detected' | 'latest' | 'v6')[];
181180
availableSchemasVersions: ('v6')[];
182181
default: {

src/patternFly.getResources.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -299,8 +299,8 @@ const getPatternFlyMcpResources = async (contextPathOverride?: string): Promise<
299299
byUri[uriSchemas]?.push(extendedEntry);
300300
}
301301

302-
byVersion[entry.version] ??= [];
303-
byVersion[entry.version]?.push(extendedEntry);
302+
byVersion[version] ??= [];
303+
byVersion[version]?.push(extendedEntry);
304304

305305
resource.urls.push(path);
306306
resource.versions[version].urls.push(path);
@@ -363,7 +363,9 @@ const getPatternFlyComponentSchema = async (componentName: string) => {
363363
}
364364

365365
return await getComponentSchema(updatedComponentName);
366-
} catch {}
366+
} catch (error) {
367+
log.debug(`Failed to get component schemas for "${componentName}": ${formatUnknownError(error)}`);
368+
}
367369

368370
return undefined;
369371
};

src/patternFly.helpers.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ const findClosestPatternFlyVersion = async (
3232
_contextPathOverride: string | undefined = undefined,
3333
options = getOptions()
3434
): Promise<string> =>
35-
options.patternflyOptions?.default?.latestSemVer;
35+
options.patternflyOptions.default.latestSemVer;
3636

3737
/**
3838
* Memoized version of findClosestPatternFlyVersion.
@@ -62,7 +62,7 @@ const getPatternFlyVersionContext = async (
6262
contextPathOverride: string | undefined = undefined,
6363
options = getOptions()
6464
): Promise<PatternFlyVersionContext> => {
65-
const availableSemVer = options.patternflyOptions?.availableResourceVersions;
65+
const availableSemVer = options.patternflyOptions?.availableResourceVersions || [];
6666
const availableVersions = availableSemVer?.map?.(version => {
6767
const majorVersion = semver.coerce(version)?.major;
6868

src/patternFly.search.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ const searchPatternFly = async (searchQuery: string, {
7777
return {
7878
isSearchWildCardAll,
7979
firstExactMatch: exactMatches[0],
80-
exactMatches: exactMatches,
80+
exactMatches,
8181
searchResults: updatedSearchResults
8282
};
8383
};

0 commit comments

Comments
 (0)