fix: review update

Author: cdcabrera

src/__tests__/__snapshots__/options.defaults.test.ts.snap

@@ -111,7 +111,7 @@ exports[`options defaults should return specific properties: defaults 1`] = `
 ---
 
 ",
-  "serverOptions": {
+  "serverInstanceOptions": {
     "instructions": "Use the PatternFly MCP when a user asks about: PatternFly, pf, pf docs, design tokens, design guidelines, accessibility, PatternFly components, and frontend development.",
   },
   "stats": {

src/__tests__/server.test.ts

@@ -153,7 +153,7 @@ describe('runServer', () => {
       {
         minMax: DEFAULT_OPTIONS.minMax,
         patternflyOptions: DEFAULT_OPTIONS.patternflyOptions,
-        serverOptions: DEFAULT_OPTIONS.serverOptions,
+        serverInstanceOptions: DEFAULT_OPTIONS.serverInstanceOptions,
         ...options
       } as any,
       Object.keys(settings).length > 0 ? settings : { allowProcessExit: false }
@@ -187,7 +187,6 @@ describe('runServer', () => {
       {
         minMax: DEFAULT_OPTIONS.minMax,
         patternflyOptions: DEFAULT_OPTIONS.patternflyOptions,
-        serverOptions: DEFAULT_OPTIONS.serverOptions,
         ...options,
         name: 'test-server'
       } as any,

src/options.defaults.ts

@@ -33,7 +33,7 @@ import { type ToolModule } from './server.toolsUser';
  * @property resourceModules - Array for programmatic registration of resource provider modules, similar to `toolModules` but
  *     for MCP resources and currently only internal.
  * @property separator - Default string delimiter.
- * @property serverOptions - Server-instance options.
+ * @property serverInstanceOptions - Server-instance options.
  * @property {StatsOptions} stats - Stats options.
  * @property {typeof TOOL_MEMO_OPTIONS} toolMemoOptions - Tool-specific memoization options.
  * @property {ToolModule|ToolModule[]} toolModules - Array of external tool modules (ESM specs or paths) to be loaded and
@@ -63,7 +63,7 @@ interface DefaultOptions<TLogOptions = LoggingOptions> {
   resourceMemoOptions: Partial<typeof RESOURCE_MEMO_OPTIONS>;
   resourceModules: unknown | unknown[];
   separator: string;
-  serverOptions: ServerOptions;
+  serverInstanceOptions: ServerInstanceOptions;
   stats: StatsOptions;
   toolMemoOptions: Partial<typeof TOOL_MEMO_OPTIONS>;
   toolModules: ToolModule | ToolModule[];
@@ -249,10 +249,10 @@ interface LoggingSession extends LoggingOptions {
 /**
  * MCP Server instance options.
  *
- * @interface ServerOptions
- * @property instructions Instructions for the MCP server.
+ * @interface ServerInstanceOptions
+ * @property instructions Instructions for the MCP server instance.
  */
-interface ServerOptions {
+interface ServerInstanceOptions {
   instructions: string;
 }
 
@@ -412,7 +412,7 @@ const TOOL_MEMO_OPTIONS = {
 /**
  * Default server instance options.
  */
-const SERVER_OPTIONS: ServerOptions = {
+const SERVER_INSTANCE_OPTIONS: ServerInstanceOptions = {
   instructions: 'Use the PatternFly MCP when a user asks about: PatternFly, pf, pf docs, design tokens, design guidelines, accessibility, PatternFly components, and frontend development.'
 };
 
@@ -517,7 +517,7 @@ const DEFAULT_OPTIONS: DefaultOptions = {
   repoName: basename(process.cwd() || '').trim(),
   repoResources: REPO_RESOURCES,
   resourceMemoOptions: RESOURCE_MEMO_OPTIONS,
-  serverOptions: SERVER_OPTIONS,
+  serverInstanceOptions: SERVER_INSTANCE_OPTIONS,
   stats: STATS_OPTIONS,
   resourceModules: [],
   toolMemoOptions: TOOL_MEMO_OPTIONS,

src/server.ts

@@ -233,6 +233,7 @@ const runServer = async (options: ServerOptions = getOptions(), {
 
   try {
     const enableProtocolLogging = options?.logging?.protocol;
+    const serverInstructions = options?.serverInstanceOptions?.instructions;
 
     server = new McpServer(
       {
@@ -245,7 +246,7 @@ const runServer = async (options: ServerOptions = getOptions(), {
           resources: {},
           ...(enableProtocolLogging ? { logging: {} } : {})
         },
-        instructions: options.serverOptions.instructions
+        ...(serverInstructions ? { instructions: serverInstructions } : {})
       }
     );